You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/13 17:31:40 UTC

[GitHub] [tvm] driazati commented on a diff in pull request #11304: Fix Hexagon build using ci.py

driazati commented on code in PR #11304:
URL: https://github.com/apache/tvm/pull/11304#discussion_r872627028


##########
tests/scripts/ci.py:
##########
@@ -195,6 +195,8 @@ def docker(name: str, image: str, scripts: List[str], env: Dict[str, str], inter
         command.append("-t")
         scripts = ["interact() {", "  bash", "}", "trap interact 0", ""] + scripts
 
+    command.append("--net=host")

Review Comment:
   it's on by default in `bash.sh` when used from a tty, and this doesn't run any random code just the CI scripts so I don't think exposing the host net will cause problems



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org