You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2014/05/30 18:29:01 UTC
[jira] [Commented] (THRIFT-2555) excessive "unused field" comments
[ https://issues.apache.org/jira/browse/THRIFT-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013906#comment-14013906 ]
Hudson commented on THRIFT-2555:
--------------------------------
SUCCESS: Integrated in Thrift #1168 (See [https://builds.apache.org/job/Thrift/1168/])
THRIFT-2555 excessive "unused field" comments (jensg: rev eb1e1d5567cabe4a4f7f58c380f651325cdba77e)
* compiler/cpp/src/generate/t_go_generator.cc
> excessive "unused field" comments
> ---------------------------------
>
> Key: THRIFT-2555
> URL: https://issues.apache.org/jira/browse/THRIFT-2555
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Fix For: 0.9.2
>
> Attachments: THRIFT-2555_excessive_unused_field_comments.patch, thrift-2555-excessive_unused-fields.thrift
>
>
> {code:title=test.thrift}
> namespace go thrift2555
> struct Element3 {
> 1 : i32 plus_1
> 10 : i32 plus_10
> }
> service FooBar {
> Element3 Convert(3: Element3 three)
> }
> {code}
> produces
> {code:title=ttypes.go}
> type Element3 struct {
> Plus_1 int32 `thrift:"plus_1,1"`
> // unused field # 2
> // unused field # 3
> // unused field # 4
> // unused field # 5
> // unused field # 6
> // unused field # 7
> // unused field # 8
> // unused field # 9
> Plus_10 int32 `thrift:"plus_10,10"`
> }
> {code}
> which starts to become annoying the larger the gaps between the numbers are.
--
This message was sent by Atlassian JIRA
(v6.2#6252)