You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/06/16 14:43:19 UTC
[GitHub] [incubator-pekko-http] pjfanning opened a new pull request, #180: add build docs
pjfanning opened a new pull request, #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180
* copied from https://github.com/apache/incubator-pekko
* in anticipation that this repo will soon head to RC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #180: add build docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1233077508
##########
README.md:
##########
@@ -22,21 +21,50 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 8 or later.
Review Comment:
Yes I know but this was for older versions of Scala. `-target` in the latest versions of Scala is either deprecated or removed and ontop of the the behaviour of `-release` has changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #180: add build docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1233067516
##########
README.md:
##########
@@ -22,21 +21,50 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 8 or later.
Review Comment:
I woukd sayJDK 8 only (i.e. remove the later part) because Pekko Http build needs to produce JDK 8 bytecode. If you build with after JDK then JDK 8 users cannot run Pekko Http.
This can be resolved with the `-release` flag which pekko http uses but with conditionals which may not be relevant now (i.e. latest versions of Scala 2 fixes some problems) but the point is we need to be careful about this and verify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #180: add build docs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1233076557
##########
README.md:
##########
@@ -22,21 +21,50 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 8 or later.
Review Comment:
this appears in our build.sbt
```
(if (isJdk8) Seq.empty
else if (scalaBinaryVersion.value == "2.12") Seq("-target:jvm-1.8")
else Seq("-release", "8")),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #180: add build docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1233074186
##########
README.md:
##########
@@ -22,21 +21,50 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 8 or later.
Review Comment:
The critical one, i.e. building jar artifacts is JDK 8 and we inherited that from Akka https://github.com/apache/incubator-pekko-http/blob/main/.github/workflows/publish.yml#L19 .
Also a distinction should be made between building release artifacts to validate release process and just working on the code locally.
I am on my phone atm so it's a bit hard to read entire thing in context but for me the important part is that it's clear that when creating release artifacts (for verification or doing the release yourself as a release manager) that you use JDK 8.
And it might well be that creating release artifacts for JDK 11 or higher is fine but after going through the process of validating/improving/clarifying this in root pekko I would rather be safe and just say "use JDK 8 for release purposes".
There are some historically hidden gremlins in the code and I would rather not poke them now unless we can verify they are not gremlins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning merged pull request #180: add build docs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #180: add build docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#issuecomment-1596224911
@pjfanning Okay so I have successfully run [jardiff](https://github.com/lightbend-labs/jardiff) on two versions of pekko-http, one built with JDK 8 and the other built with JDK 11 using
```
jardiff -g ~/github/diff-temp/ ~/github/incubator-pekko-http/http-core/target/scala-2.12/ ~/github/incubator-pekko-http-2/http-core/target/scala-2.12/
```
and as I suspected we have the problem I noted before
(this is with `HttpHeaderParser$.class`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #180: add build docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1241948767
##########
README.md:
##########
@@ -22,21 +21,50 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 8 or later.
Review Comment:
I verified the bytecode using sbt jardiff that with the latest `-release` flag that was improved in latest versions if Scala 2 (and was always fixed in Scala 3) that you can build with JDK 11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #180: add build docs
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1241828960
##########
README.md:
##########
@@ -22,21 +21,50 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 8 or later.
Review Comment:
The safe option is to build with JDK 8. The compatibility mode of JDK 11 will probably work most of the times but we ran into issues in the past, where the JDK signature storage that allows JDK 11 to figure out which methods are present in JDK 8 was not completely accurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #180: add build docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1232401808
##########
README.md:
##########
@@ -22,21 +21,52 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 11 or later.
+- Make sure you have [sbt](https://www.scala-sbt.org/) installed and using this JDK.
+- Make sure you also have Java 8 installed (JDK or JRE).
Review Comment:
I don't think you need JDK 8 and JDK 11 for pekko-http or for other pekko modules for that matter. The weird hybrid setup we have with pekko is only unique to pekko.
With pekko-http currently it looks like you need to build with JDK 8. We might be able to get away with later versions of JDK by using the `-release` flag but we would have to confirm this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #180: add build docs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1232426430
##########
README.md:
##########
@@ -22,21 +21,52 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 11 or later.
+- Make sure you have [sbt](https://www.scala-sbt.org/) installed and using this JDK.
+- Make sure you also have Java 8 installed (JDK or JRE).
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #180: add build docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1233077508
##########
README.md:
##########
@@ -22,21 +21,50 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 8 or later.
Review Comment:
Yes I know but this was for older versions of Scala that was inherited and since then in newer versions of Scala (which we use now) `-target` has either deprecated or removed and ontop of the the behaviour of `-release` has changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #180: add build docs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1233068659
##########
README.md:
##########
@@ -22,21 +21,50 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 8 or later.
Review Comment:
our pekko repo says JDK 11+
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #180: add build docs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1233089609
##########
README.md:
##########
@@ -22,21 +21,50 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 8 or later.
Review Comment:
I built pekko-http on my laptop with JDK11 and was then able to use the jars that I published to MavenLocal with JDK 8 builds of downstream projects. The classes appear to be Java 8 format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #180: add build docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#issuecomment-1596260669
@pjfanning I have just created https://github.com/apache/incubator-pekko-http/pull/187 which allows building correct artifacts for pekko-http with JDK 11 so you can use the original documentation that you provided in this PR.
Once that PR is merged I can approve this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #180: add build docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#issuecomment-1596156620
@pjfanning So I haven't had proper time to check this, but the issue I am concerned about specifically is https://github.com/classgraph/classgraph/issues/403#issuecomment-586770739 and https://github.com/apache/incubator-pekko/pull/258/files#diff-c11a10bd9e773399e4272cd1ee5dff72545afb2f8bed23f2d1bbc49d4e1fc03fL60-L67 . JDK 9+ introduced a very subtle but possible breaking change from the JDK 8 standard library. If the problem is there, you won't hit at compile time, you hit them at runtime and only if you hit specific codepaths i.e. code that calls `byteBuffer.clear()` (and I briefly checked pekko-http and it does call this code).
To confirm that there isn't a problem I have to manually inspect the bytecode, just like I did here https://github.com/apache/incubator-pekko/pull/258#issuecomment-1477908162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #180: add build docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#issuecomment-1596248444
@pjfanning I managed to fix the issue that I described earlier that will let you produce jars correctly on JDK 11, will create the PR soon (having dinner now)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #180: add build docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1233067516
##########
README.md:
##########
@@ -22,21 +21,50 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 8 or later.
Review Comment:
I would say JDK 8 only (i.e. remove the later part) because Pekko Http build needs to produce JDK 8 bytecode. If you build with after JDK then JDK 8 users cannot run Pekko Http.
This can be resolved with the `-release` flag which pekko http uses but with conditionals which may not be relevant now (i.e. latest versions of Scala 2 fixes some problems) but the point is we need to be careful about this and verify it.
In summary, it's safer to just say "JDK 8" only for now, at least until we confirm that it works fine for later JDKs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #180: add build docs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1233068528
##########
README.md:
##########
@@ -22,21 +21,50 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 8 or later.
Review Comment:
the point here is to let users build as they wish but to help them - some users might want java 11 - why not let them?
there is no mention here that the result is a binary match to the jars that we release
we have CI builds that prove you can build with java 11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #180: add build docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1233074186
##########
README.md:
##########
@@ -22,21 +21,50 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 8 or later.
Review Comment:
The critical one, i.e. building jar artifacts is JDK 8 and we inherited that from Akka https://github.com/apache/incubator-pekko-http/blob/main/.github/workflows/publish.yml#L19 .
Also a distinction should be made between building release artifacts to validate release process and just working on the code locally.
I am on my phone atm so it's a bit hard to read entire thing in context but for me the important part is that it's clear that when creating release artifacts (for verification or doing the release yourself as a release manager) that you use JDK 8.
And it might well be that creating release artifacts for JDK 11 or higher is fine but after going through the process of validating/improving/clarifying this in root pekko I would rather be safe and just say "use JDK 8 for release purposes".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #180: add build docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1241948767
##########
README.md:
##########
@@ -22,21 +21,50 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 8 or later.
Review Comment:
I verified the bytecode using sbt jardiff that with the latest `-release` flag that was improved in latest versions if Scala 2 (and was always fixed in Scala 3) that you can build with JDK 11
See https://github.com/apache/incubator-pekko-http/pull/187 for more details
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on pull request #180: add build docs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#issuecomment-1595764770
> Only Pekko needs dual JDK's, currently Pekko-Http only needs JDK 8.
@mdedetrich I made the change to remove the mention of having 2 JDKs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #180: add build docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1233074186
##########
README.md:
##########
@@ -22,21 +21,50 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 8 or later.
Review Comment:
The critical one, i.e. building jar artifacts is JDK 8 and we inherited that from Akka https://github.com/apache/incubator-pekko-http/blob/main/.github/workflows/publish.yml#L19 .
Also a distinction should be made between building release artifacts to validate release process and just working on the code locally.
I am on my phone atm so it's a bit hard to read entire thing in context but for me the important part is that it's clear that when creating release artifacts (for verification or doing the release yourself as a release manager) that you use JDK 8.
And it might well be that it creating release artifacts for JDK 11 or higher is fine but after going through the process of validating/improving/clarifying this in root pekko I would rather be safe and just say "use JDK 8 for release purposes".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #180: add build docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1233074186
##########
README.md:
##########
@@ -22,21 +21,50 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 8 or later.
Review Comment:
The critical one, i.e. building jar artifacts is JDK 8 and we inherited that from Akka https://github.com/apache/incubator-pekko-http/blob/main/.github/workflows/publish.yml#L19 .
Also a distinction should be made between building release artifacts to validate release process and just working on the code locally.
I am on my phone atm so it's a bit hard to read entire thing in context but for me the important part is that it's clear that when creating release artifacts (for verification or doing the release yourself as a release manager) that you use JDK 8.
And it might well be that it cresting release artifacts for JDK 11 or higher is fine but after going through the process of validating/improving/clarifying this in root pekko i would rather be safe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #180: add build docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #180:
URL: https://github.com/apache/incubator-pekko-http/pull/180#discussion_r1233095536
##########
README.md:
##########
@@ -22,21 +21,50 @@ might require you to write more application code.
Learn more at [pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/).
-Documentation
--------------
+## Documentation
The documentation is available at
[pekko.apache.org](https://pekko.apache.org/docs/pekko-http/current/), for
[Scala](https://pekko.apache.org/docs/pekko-http/current/scala/http/) and
[Java](https://pekko.apache.org/docs/pekko-http/current/java/http/).
-
-Community
----------
+## Building from Source
+
+### Prerequisites
+- Make sure you have installed a Java Development Kit (JDK) version 8 or later.
Review Comment:
I am more concerned about stuff like unsafe or missing references to documentation. I'll check this properly when I get home
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org