You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/06 13:01:33 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5179: arch/sim: Move spiflash simulation to drivers/spi instead
xiaoxiang781216 commented on a change in pull request #5179:
URL: https://github.com/apache/incubator-nuttx/pull/5179#discussion_r779530236
##########
File path: arch/sim/src/sim/up_initialize.c
##########
@@ -125,12 +128,12 @@ static void up_init_smartfs(void)
}
}
#endif
-#endif /* CONFIG_SIM_SPIFLASH */
+#endif /* CONFIG_SPI_FLASH */
Review comment:
Done.
##########
File path: drivers/spi/qspi_flash.c
##########
@@ -178,22 +171,22 @@ struct sim_qspiflashdev_s
/* QSPI methods */
-static int qspiflash_lock(FAR struct qspi_dev_s *dev, bool lock);
-static uint32_t qspiflash_setfrequency(FAR struct qspi_dev_s *dev,
+static int qspi_flash_lock(FAR struct qspi_dev_s *dev, bool lock);
+static uint32_t qspi_flash_setfrequency(FAR struct qspi_dev_s *dev,
uint32_t frequency);
Review comment:
Done.
##########
File path: drivers/spi/qspi_flash.c
##########
@@ -178,22 +171,22 @@ struct sim_qspiflashdev_s
/* QSPI methods */
-static int qspiflash_lock(FAR struct qspi_dev_s *dev, bool lock);
-static uint32_t qspiflash_setfrequency(FAR struct qspi_dev_s *dev,
+static int qspi_flash_lock(FAR struct qspi_dev_s *dev, bool lock);
+static uint32_t qspi_flash_setfrequency(FAR struct qspi_dev_s *dev,
uint32_t frequency);
-static void qspiflash_setmode(FAR struct qspi_dev_s *dev,
+static void qspi_flash_setmode(FAR struct qspi_dev_s *dev,
enum qspi_mode_e mode);
-static void qspiflash_setbits(FAR struct qspi_dev_s *dev, int nbits);
-static int qspiflash_command(FAR struct qspi_dev_s *dev,
+static void qspi_flash_setbits(FAR struct qspi_dev_s *dev, int nbits);
+static int qspi_flash_command(FAR struct qspi_dev_s *dev,
FAR struct qspi_cmdinfo_s *cmd);
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org