You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/13 01:06:41 UTC
[jira] [Commented] (CB-11895) openURL deprecated in iOS 10 (new
selector replaces it)
[ https://issues.apache.org/jira/browse/CB-11895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966955#comment-15966955 ]
ASF GitHub Bot commented on CB-11895:
-------------------------------------
GitHub user kerrishotts opened a pull request:
https://github.com/apache/cordova-ios/pull/302
CB-11895: openURL: is deprecated on iOS 10
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
- iOS
### What does this PR do?
Addresses deprecation of openURL: in iOS 10 by using openURL:options:completionHandler: instead.
### What testing has been done on this change?
- CI Testing OK
- Tested in sim on 10.3 and 9.3 & verified appropriate methods were called
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
- not applicable to this change
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kerrishotts/cordova-ios CB-11895
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/302.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #302
----
commit 7e9a22efcdcd085b68970dca61156e6995586e25
Author: Kerri Shotts <ke...@gmail.com>
Date: 2017-04-12T21:02:57Z
CB-11895: openURL: is deprecated on iOS 10
----
> openURL deprecated in iOS 10 (new selector replaces it)
> -------------------------------------------------------
>
> Key: CB-11895
> URL: https://issues.apache.org/jira/browse/CB-11895
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
> Reporter: Shazron Abdullah
> Assignee: Kerri Shotts
> Labels: easyfix
> Fix For: cordova-ios@4.4.0
>
>
> Article:
> http://useyourloaf.com/blog/openurl-deprecated-in-ios10
> Our usage:
> https://github.com/apache/cordova-ios/blob/3bda0ef487f204e60def4ff1ecf844862460313e/CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m#L121
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org