You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/18 13:07:01 UTC
[GitHub] [spark] yaooqinn opened a new pull request #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
yaooqinn opened a new pull request #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
pattern `''` means literal `'`
```sql
select date_format(to_timestamp("11111904-01-23 15:02:01", 'y-MM-dd HH:mm:ss'), "y-MM-dd HH:mm:ss''SSSSSSSSS");
5377-02-14 06:27:19'000000519
```
https://github.com/apache/spark/commit/0946a9514f56565c78b0555383c1ece14aaf2b7b missed this case and this pr add it back.
### Why are the changes needed?
bugfix
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
add ut
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600614718
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600637727
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600637738
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24714/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600771552
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119991/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600613215
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600771542
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600636968
**[Test build #119993 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119993/testReport)** for PR 27949 at commit [`3e2b2c2`](https://github.com/apache/spark/commit/3e2b2c206bc2eb60a5e65bad64b92f49121a877c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600793677
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119993/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600614718
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on issue #27949:
[SPARK-31150][SQL][Followup] Handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on issue #27949: [SPARK-31150][SQL][Followup] Handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-603605312
@yaooqinn Please fix the title next time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600637738
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24714/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600770444
**[Test build #119991 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119991/testReport)** for PR 27949 at commit [`1f2d056`](https://github.com/apache/spark/commit/1f2d05693484c895802ac5b58dcde3c187a461c8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600793667
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600637727
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#discussion_r394337337
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -117,6 +117,7 @@ private object DateTimeFormatterHelper {
pattern: String): DateTimeFormatterBuilder = {
val builder = createBuilder()
pattern.split("'").zipWithIndex.foreach {
+ case ("", idx) if idx != 0 => builder.appendLiteral("'")
Review comment:
can we add some comment to explain why `idx != 0`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600793667
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600614119
**[Test build #119991 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119991/testReport)** for PR 27949 at commit [`1f2d056`](https://github.com/apache/spark/commit/1f2d05693484c895802ac5b58dcde3c187a461c8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600771542
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#discussion_r394360710
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -117,6 +117,7 @@ private object DateTimeFormatterHelper {
pattern: String): DateTimeFormatterBuilder = {
val builder = createBuilder()
pattern.split("'").zipWithIndex.foreach {
+ case ("", idx) if idx != 0 => builder.appendLiteral("'")
Review comment:
comment add, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on issue #27949:
[SPARK-31150][SQL][Followup] Handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #27949: [SPARK-31150][SQL][Followup] Handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-603606506
thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600614727
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24712/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600793677
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119993/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600890522
Thanks! Merged to master/3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600614727
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24712/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600771552
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119991/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600614119
**[Test build #119991 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119991/testReport)** for PR 27949 at commit [`1f2d056`](https://github.com/apache/spark/commit/1f2d05693484c895802ac5b58dcde3c187a461c8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600792643
**[Test build #119993 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119993/testReport)** for PR 27949 at commit [`3e2b2c2`](https://github.com/apache/spark/commit/3e2b2c206bc2eb60a5e65bad64b92f49121a877c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#discussion_r394360710
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -117,6 +117,7 @@ private object DateTimeFormatterHelper {
pattern: String): DateTimeFormatterBuilder = {
val builder = createBuilder()
pattern.split("'").zipWithIndex.foreach {
+ case ("", idx) if idx != 0 => builder.appendLiteral("'")
Review comment:
comment added, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949#issuecomment-600636968
**[Test build #119993 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119993/testReport)** for PR 27949 at commit [`3e2b2c2`](https://github.com/apache/spark/commit/3e2b2c206bc2eb60a5e65bad64b92f49121a877c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #27949:
[SPARK-31150][SQL][Followup] handle ' as escape for text
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #27949: [SPARK-31150][SQL][Followup] handle ' as escape for text
URL: https://github.com/apache/spark/pull/27949
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org