You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "Mark Payne (JIRA)" <ji...@apache.org> on 2015/04/28 17:23:07 UTC

[jira] [Commented] (NIFI-421) ExecuteProcess does not honor back pressure setting

    [ https://issues.apache.org/jira/browse/NIFI-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517191#comment-14517191 ] 

Mark Payne commented on NIFI-421:
---------------------------------

Toivo,

Sorry it's taken so long for anyone to get back to you on this. 

There has been a lot of craziness going on lately. Unfortunately, the patch that you uploaded shows that the processor was removed and then a new implementation provided, it seems. 
Any chance that you can re-generate the patch so that it shows what changed? It's really difficult to review the patch as-is because it shows it as a complete replace, and with the checkstyle stuff getting added in, basically every file in the repo has been modified so that it's easier analyze patches - but unfortunately that creates a lot of headaches right now.

Thanks
-Mark

> ExecuteProcess does not honor back pressure setting
> ---------------------------------------------------
>
>                 Key: NIFI-421
>                 URL: https://issues.apache.org/jira/browse/NIFI-421
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Joseph Witt
>            Assignee: Toivo Adams
>              Labels: beginner
>             Fix For: 0.1.0
>
>         Attachments: NIFI-421_07apr2015.patch, TestExecuteProcess.java
>
>
> ExecuteProcess does not pay attention to back pressure settings when operating on a continuous stream of output.  It needs to be able to do so.  It should also document or make optional its behavior in the event of a back pressure condition.  One it can kill the process it is executing or two it can simply stop reading from the output stream.  There may be valid cases for both options.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)