You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "naturzukunft (via GitHub)" <gi...@apache.org> on 2024/02/18 13:33:44 UTC
[PR] update to jena 4.10.0 (without osgi) [commons-rdf]
naturzukunft opened a new pull request, #196:
URL: https://github.com/apache/commons-rdf/pull/196
Hi there,
i think I would like to use commons-rdf, but not with the old Jena version. So here is a PR for a new version. I have no idea about osgi and jena doesn't seem to support it anymore. so I just used the non osgi dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update to jena 4.10.0 (without osgi) [commons-rdf]
Posted by "naturzukunft (via GitHub)" <gi...@apache.org>.
naturzukunft commented on PR #196:
URL: https://github.com/apache/commons-rdf/pull/196#issuecomment-1953572503
first attempts with `org.apache.jena:jena-commonsrdf:4.10.0` look promising. It looks like I don't have to rely on the changes in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update to jena 4.10.0 (without osgi) [commons-rdf]
Posted by "naturzukunft (via GitHub)" <gi...@apache.org>.
naturzukunft closed pull request #196: update to jena 4.10.0 (without osgi)
URL: https://github.com/apache/commons-rdf/pull/196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update to jena 4.10.0 (without osgi) [commons-rdf]
Posted by "naturzukunft (via GitHub)" <gi...@apache.org>.
naturzukunft commented on PR #196:
URL: https://github.com/apache/commons-rdf/pull/196#issuecomment-1951415525
@afs
unfortunately, i no longer have the example from the beginning. I would have to make it again. Let's see if I can do it in the next few days. Working for money again tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update to jena 4.10.0 (without osgi) [commons-rdf]
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #196:
URL: https://github.com/apache/commons-rdf/pull/196#issuecomment-1951341137
Thank you. Allowed GitHub Actions to run, waiting for the build. There's a current Jena 5 RC vote open too, I think (or it might have been released recently). So would be good to check if we can bump it up to 5.x at some point too. Cheers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update to jena 4.10.0 (without osgi) [commons-rdf]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #196:
URL: https://github.com/apache/commons-rdf/pull/196#issuecomment-1951349334
This PR breaks the build. We would need to bump the Java requirement for this project from Java 8 to 11. This is not something we can decide here, it needs to be brought up on the dev mailing list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update to jena 4.10.0 (without osgi) [commons-rdf]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #196:
URL: https://github.com/apache/commons-rdf/pull/196#issuecomment-1953069930
> ```
> <dependency>
> <groupId>org.apache.commons</groupId>
> <artifactId>commons-rdf-jena</artifactId>
> <version>0.5.0</version>
> </dependency>
> ```
`jena-osgi:3.5.0` does not include `jena-tdb2` which would explain why `TDB2Factory` isn't visible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update to jena 4.10.0 (without osgi) [commons-rdf]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #196:
URL: https://github.com/apache/commons-rdf/pull/196#issuecomment-1951378506
@naturzukunft -
Jena provides an artifact for an implementation RDF Commons that in included in every Jena release. It does this to ensure there is a jena-version-aligned implementation.
https://repo1.maven.org/maven2/org/apache/jena/jena-commonsrdf/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update to jena 4.10.0 (without osgi) [commons-rdf]
Posted by "naturzukunft (via GitHub)" <gi...@apache.org>.
naturzukunft commented on PR #196:
URL: https://github.com/apache/commons-rdf/pull/196#issuecomment-2015538013
currently using a custom rdf4j implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update to jena 4.10.0 (without osgi) [commons-rdf]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #196:
URL: https://github.com/apache/commons-rdf/pull/196#issuecomment-1951380844
The Jena project policy is "2 LTS".
Jena 4.x requires Java11; Jena 5.x requires Java17.
While free support for Java8 is available in some distributions (October 2026 for Eclipse Temurin) it is not universal.
and Eclipse Temurin has only said that Java11 is supported until October 2024. A sign of Java moving to the more regular release cycle.
From the Jena's project experience, bugs are not all backported, only major ones and security related ones.
As a project Jena, isn't in a position to have multiple release branches without addition active contribution for that task. Restricting to Java8 would probably discourage contributors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update to jena 4.10.0 (without osgi) [commons-rdf]
Posted by "naturzukunft (via GitHub)" <gi...@apache.org>.
naturzukunft commented on PR #196:
URL: https://github.com/apache/commons-rdf/pull/196#issuecomment-1953008674
> @naturzukunft -
>
> Jena provides an artifact for an implementation RDF Commons that in included in every Jena release. It does this to ensure there is a jena-version-aligned implementation.
>
> https://repo1.maven.org/maven2/org/apache/jena/jena-commonsrdf/
I am beginning to understand.
```xml
<dependency>
<groupId>org.apache.jena</groupId>
<artifactId>jena-commonsrdf</artifactId>
<version>4.10.0</version>
</dependency>
```
is the jena "answer" for:
```xml
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-rdf-jena</artifactId>
<version>0.5.0</version>
</dependency>
```
Do I understand correctly that it would be better to do without `org.apache.commons:commons-rdf-jena` ?
I would like to say that it makes no sense to "renew" the artifact, since there is already an implementation of jena. It would probably be better to delete `org.apache.commons:commons-rdf-jena`.
I'm going to play with it some more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update to jena 4.10.0 (without osgi) [commons-rdf]
Posted by "naturzukunft (via GitHub)" <gi...@apache.org>.
naturzukunft commented on PR #196:
URL: https://github.com/apache/commons-rdf/pull/196#issuecomment-1952958361
> @afs unfortunately, i no longer have the example from the beginning. I would have to make it again. Let's see if I can do it in the next few days. Working for money again tomorrow.
I have now tried to recreate the example:
```java
package com.example;
import java.util.UUID;
import org.apache.commons.rdf.api.Graph;
import org.apache.commons.rdf.api.IRI;
import org.apache.commons.rdf.api.RDF;
import org.apache.commons.rdf.jena.JenaGraph;
import org.apache.commons.rdf.jena.JenaRDF;
import org.apache.jena.query.ReadWrite;
import org.apache.jena.rdf.model.Model;
import org.apache.jena.tdb.TDBFactory;
public class Test {
public static void main(String[] args) {
org.apache.jena.query.Dataset jenaDataset = TDBFactory.createDataset("target/test");
RDF rdf = new JenaRDF();
IRI namePredicate = rdf.createIRI("https://schema.org/name");
String graphNameAsString = "http://example.com/myGraph";
IRI myGraphNameAsIri = rdf.createIRI(graphNameAsString);
// READ TDB dataset
Graph myCommonsGraph4Read = ((JenaRDF)rdf).asDataset(jenaDataset).getGraph(myGraphNameAsIri).orElseThrow(()->new IllegalStateException());
myCommonsGraph4Read.stream().forEach(quad->System.out.println("commonsQuad: " + quad));
// Write TDB dataset
jenaDataset.begin(ReadWrite.WRITE);
Graph commonsRdfGraph4Write = ((JenaRDF)rdf).asDataset(jenaDataset).getGraph(myGraphNameAsIri).orElseThrow(()->new IllegalStateException());
IRI randomSubject = rdf.createIRI("http://example.com/"+ UUID.randomUUID().toString());
commonsRdfGraph4Write.add(randomSubject, namePredicate, rdf.createLiteral("Bob"));
Model jenaModel = ((JenaGraph)commonsRdfGraph4Write).asJenaModel();
jenaDataset.addNamedModel(graphNameAsString, jenaModel);
jenaDataset.commit();
jenaDataset.end();
}
}
```
```xml
[commons-rdf-test.zip](https://github.com/apache/commons-rdf/files/14335511/commons-rdf-test.zip)
<dependencies>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-rdf-api</artifactId>
<version>0.5.0</version>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-rdf-jena</artifactId>
<version>0.5.0</version>
</dependency>
</dependencies>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update to jena 4.10.0 (without osgi) [commons-rdf]
Posted by "naturzukunft (via GitHub)" <gi...@apache.org>.
naturzukunft commented on PR #196:
URL: https://github.com/apache/commons-rdf/pull/196#issuecomment-1959628063
RDF4J 4.0.0 -> Update to Java 11 as the minimally-required version of Java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update to jena 4.10.0 (without osgi) [commons-rdf]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #196:
URL: https://github.com/apache/commons-rdf/pull/196#issuecomment-1951404192
@naturzukunft
I don't have the background here. What trouble?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update to jena 4.10.0 (without osgi) [commons-rdf]
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #196:
URL: https://github.com/apache/commons-rdf/pull/196#issuecomment-1951351090
> This PR breaks the build. We would need to bump the Java requirement for this project from Java 8 to 11. This is not something we can decide here, it needs to be brought up on the dev mailing list.
Good point, @garydgregory . From commons-rdf readme,
>aims to provide a common library for [RDF 1.1](http://www.w3.org/TR/rdf11-concepts/) with implementations for common Java RDF frameworks like [RDF4J](http://rdf4j.org/), [Apache Jena](http://jena.apache.org/) as well as for other libraries such as [OWLAPI](http://owlapi.sourceforge.net/), [Clerezza](http://clerezza.apache.org/) and other JVM languages.
Jena, from what I remember, updates JVM versions faster than Commons components (cannot remember if it's the last three version, three years? @afs ).
Maybe commons-rdf will have to break away from other Commons components, and use the lowest version of the JVM that works with the latest supported version of the libraries it wants to interface with. +1 to the mailing list discussion :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update to jena 4.10.0 (without osgi) [commons-rdf]
Posted by "naturzukunft (via GitHub)" <gi...@apache.org>.
naturzukunft commented on PR #196:
URL: https://github.com/apache/commons-rdf/pull/196#issuecomment-1951384806
@afs Hm, the trouble started when I replaced TDB1 with TDB2. That was the reason for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] update to jena 4.10.0 (without osgi) [commons-rdf]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #196:
URL: https://github.com/apache/commons-rdf/pull/196#issuecomment-1953068218
> > @naturzukunft -
> > Jena provides an artifact for an implementation RDF Commons that in included in every Jena release. It does this to ensure there is a jena-version-aligned implementation.
> > https://repo1.maven.org/maven2/org/apache/jena/jena-commonsrdf/
>
> I am beginning to understand.
>
> ```
> <dependency>
> <groupId>org.apache.jena</groupId>
> <artifactId>jena-commonsrdf</artifactId>
> <version>4.10.0</version>
> </dependency>
> ```
>
> is the jena "answer" for:
>
> ```
> <dependency>
> <groupId>org.apache.commons</groupId>
> <artifactId>commons-rdf-jena</artifactId>
> <version>0.5.0</version>
> </dependency>
> ```
>
> Do I understand correctly that it would be better to do without `org.apache.commons:commons-rdf-jena` ?
Yes.
The dependency tree of current Jena development: `jena-commonsrdf` depends on `commons-rdf-api`.
```
[INFO] --- dependency:3.6.1:tree (default-cli) @ jena-commonsrdf ---
[INFO] org.apache.jena:jena-commonsrdf:jar:5.0.0-SNAPSHOT
[INFO] +- org.apache.jena:jena-arq:jar:5.0.0-SNAPSHOT:compile
[INFO] | +- org.apache.jena:jena-core:jar:5.0.0-SNAPSHOT:compile
. . .
[INFO] +- org.apache.commons:commons-rdf-api:jar:0.5.0:compile
[INFO] +- org.apache.commons:commons-rdf-api:jar:tests:0.5.0:test
[INFO] +- org.apache.commons:commons-rdf-simple:jar:0.5.0:test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org