You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ol...@apache.org on 2022/03/27 20:16:47 UTC

[sling-org-apache-sling-clam] 24/44: [checkstyle] (coding) IllegalCatch

This is an automated email from the ASF dual-hosted git repository.

olli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-clam.git

commit a0c24f101074dcf58bd674786df0cbc1d9d61ff2
Author: Oliver Lietz <ol...@apache.org>
AuthorDate: Sun Mar 27 14:18:22 2022 +0200

    [checkstyle] (coding) IllegalCatch
---
 .../java/org/apache/sling/clam/http/internal/ClamEventsServlet.java   | 1 +
 .../java/org/apache/sling/clam/http/internal/ClamJcrScanServlet.java  | 1 +
 src/main/java/org/apache/sling/clam/http/internal/RequestUtil.java    | 4 ++++
 .../apache/sling/clam/job/internal/JcrPropertyScanJobConsumer.java    | 2 ++
 .../sling/clam/oak/internal/NodeObservingJcrPropertyDigger.java       | 1 +
 .../sling/clam/result/internal/MailSendingScanResultHandler.java      | 2 ++
 6 files changed, 11 insertions(+)

diff --git a/src/main/java/org/apache/sling/clam/http/internal/ClamEventsServlet.java b/src/main/java/org/apache/sling/clam/http/internal/ClamEventsServlet.java
index 9696c5c..e29128e 100644
--- a/src/main/java/org/apache/sling/clam/http/internal/ClamEventsServlet.java
+++ b/src/main/java/org/apache/sling/clam/http/internal/ClamEventsServlet.java
@@ -194,6 +194,7 @@ public final class ClamEventsServlet extends HttpServlet implements JcrPropertyS
             }
         }
 
+        @SuppressWarnings("checkstyle:IllegalCatch")
         private void addEvent(final Event event) {
             logger.debug("adding event: {}", event);
             events.add(event);
diff --git a/src/main/java/org/apache/sling/clam/http/internal/ClamJcrScanServlet.java b/src/main/java/org/apache/sling/clam/http/internal/ClamJcrScanServlet.java
index 4da18c0..e61229f 100644
--- a/src/main/java/org/apache/sling/clam/http/internal/ClamJcrScanServlet.java
+++ b/src/main/java/org/apache/sling/clam/http/internal/ClamJcrScanServlet.java
@@ -117,6 +117,7 @@ public final class ClamJcrScanServlet extends SlingAllMethodsServlet {
     }
 
     @Override
+    @SuppressWarnings("checkstyle:IllegalCatch")
     protected void doPost(@NotNull final SlingHttpServletRequest request, @NotNull final SlingHttpServletResponse response) throws ServletException, IOException {
         final List<String> groups = Arrays.asList(configuration.scan_authorized_groups());
         if (!groups.isEmpty()) {
diff --git a/src/main/java/org/apache/sling/clam/http/internal/RequestUtil.java b/src/main/java/org/apache/sling/clam/http/internal/RequestUtil.java
index f682baf..094bc7c 100644
--- a/src/main/java/org/apache/sling/clam/http/internal/RequestUtil.java
+++ b/src/main/java/org/apache/sling/clam/http/internal/RequestUtil.java
@@ -48,6 +48,7 @@ public final class RequestUtil {
         }
     }
 
+    @SuppressWarnings("checkstyle:IllegalCatch")
     static Pattern pattern(@NotNull final SlingHttpServletRequest request, @NotNull final Pattern defaultPattern) throws Exception {
         final String value = request.getParameter("pattern");
         if (value == null) {
@@ -61,6 +62,7 @@ public final class RequestUtil {
         }
     }
 
+    @SuppressWarnings("checkstyle:IllegalCatch")
     static Set<Integer> propertyTypes(@NotNull final SlingHttpServletRequest request, @NotNull final Set<Integer> defaultPropertyTypes) throws Exception {
         final String[] values = request.getParameterValues("propertyTypes");
         if (values == null || values.length == 0) {
@@ -73,6 +75,7 @@ public final class RequestUtil {
         }
     }
 
+    @SuppressWarnings("checkstyle:IllegalCatch")
     static long maxLength(@NotNull final SlingHttpServletRequest request, final long defaultMaxLength) throws Exception {
         final String value = request.getParameter("maxLength");
         if (value == null) {
@@ -86,6 +89,7 @@ public final class RequestUtil {
         }
     }
 
+    @SuppressWarnings("checkstyle:IllegalCatch")
     static int maxDepth(@NotNull final SlingHttpServletRequest request, final int defaultMaxDepth) throws Exception {
         final String value = request.getParameter("maxDepth");
         if (value == null) {
diff --git a/src/main/java/org/apache/sling/clam/job/internal/JcrPropertyScanJobConsumer.java b/src/main/java/org/apache/sling/clam/job/internal/JcrPropertyScanJobConsumer.java
index 8571b64..998653b 100644
--- a/src/main/java/org/apache/sling/clam/job/internal/JcrPropertyScanJobConsumer.java
+++ b/src/main/java/org/apache/sling/clam/job/internal/JcrPropertyScanJobConsumer.java
@@ -91,6 +91,7 @@ public final class JcrPropertyScanJobConsumer implements JobConsumer {
     }
 
     @Override
+    @SuppressWarnings("checkstyle:IllegalCatch")
     public JobResult process(final Job job) {
         try (ResourceResolver resourceResolver = resourceResolverFactory.getServiceResourceResolver(null)) {
             final String path = job.getProperty(ClamUtil.PROPERTY_PATH, String.class);
@@ -131,6 +132,7 @@ public final class JcrPropertyScanJobConsumer implements JobConsumer {
         }
     }
 
+    @SuppressWarnings("checkstyle:IllegalCatch")
     private void invokeScanResultHandlers(final ScanResult scanResult, final String path, final Integer index, final int propertyType, final String userId) {
         if (scanResultHandlers != null) {
             for (final JcrPropertyScanResultHandler scanResultHandler : scanResultHandlers) {
diff --git a/src/main/java/org/apache/sling/clam/oak/internal/NodeObservingJcrPropertyDigger.java b/src/main/java/org/apache/sling/clam/oak/internal/NodeObservingJcrPropertyDigger.java
index 3306e1f..4511b2b 100644
--- a/src/main/java/org/apache/sling/clam/oak/internal/NodeObservingJcrPropertyDigger.java
+++ b/src/main/java/org/apache/sling/clam/oak/internal/NodeObservingJcrPropertyDigger.java
@@ -198,6 +198,7 @@ public final class NodeObservingJcrPropertyDigger extends NodeObserver {
         }
 
         @Override
+        @SuppressWarnings("checkstyle:IllegalCatch")
         public void run() {
             final Set<String> paths = filter(path, names, pattern);
             try (ResourceResolver resourceResolver = resourceResolverFactory.getServiceResourceResolver(null)) {
diff --git a/src/main/java/org/apache/sling/clam/result/internal/MailSendingScanResultHandler.java b/src/main/java/org/apache/sling/clam/result/internal/MailSendingScanResultHandler.java
index 7454553..70d4e2e 100644
--- a/src/main/java/org/apache/sling/clam/result/internal/MailSendingScanResultHandler.java
+++ b/src/main/java/org/apache/sling/clam/result/internal/MailSendingScanResultHandler.java
@@ -104,6 +104,7 @@ public final class MailSendingScanResultHandler implements JcrPropertyScanResult
     }
 
     @Override
+    @SuppressWarnings("checkstyle:IllegalCatch")
     public void handleJcrPropertyScanResult(@NotNull final ScanResult scanResult, @NotNull final String path, final int propertyType, @Nullable final String userId) {
         if (checkPublish(scanResult)) {
             final Map<String, Object> properties = properties(path, userId, scanResult);
@@ -116,6 +117,7 @@ public final class MailSendingScanResultHandler implements JcrPropertyScanResult
     }
 
     @Override
+    @SuppressWarnings("checkstyle:IllegalCatch")
     public void handleJcrPropertyScanResult(@NotNull final ScanResult scanResult, @NotNull final String path, final int index, final int propertyType, @Nullable final String userId) {
         if (checkPublish(scanResult)) {
             final Map<String, Object> properties = properties(path, index, userId, scanResult);