You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/22 14:09:41 UTC

[GitHub] [arrow] raulcd commented on a diff in pull request #13939: ARROW-17494: [C++] Fix substrait tests linkage on static builds

raulcd commented on code in PR #13939:
URL: https://github.com/apache/arrow/pull/13939#discussion_r951488544


##########
cpp/src/arrow/engine/CMakeLists.txt:
##########
@@ -58,7 +58,11 @@ foreach(LIB_TARGET ${ARROW_SUBSTRAIT_LIBRARIES})
   target_compile_definitions(${LIB_TARGET} PRIVATE ARROW_ENGINE_EXPORTING)
 endforeach()
 
-set(ARROW_SUBSTRAIT_TEST_LINK_LIBS ${ARROW_SUBSTRAIT_LINK_lIBS} ${ARROW_TEST_LINK_LIBS})
+if(NOT ARROW_SUBSTRAIT_LINK_LIBS)
+  set(ARROW_SUBSTRAIT_LINK_LIBS substrait)

Review Comment:
   even-though this fixes the issue I am quite confused on why `list(APPEND ARROW_SUBSTRAIT_TEST_LINK_LIBS arrow_substrait_static)` is not containing `substrait` as a dependency to be linked statically as I would have expected. I've been able to reproduce also on `UBUNTU=22.04`.
   @lidavidm what do you think? Any idea on a different approach I could take on this one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org