You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/12/04 17:09:53 UTC

[GitHub] [druid] jon-wei commented on pull request #10625: Add option for maxBytesInMemory to be percentage of JVM memory

jon-wei commented on pull request #10625:
URL: https://github.com/apache/druid/pull/10625#issuecomment-738896269


   I think it would be better to make a new separate parameter that applies a percentage-based limit, and make it mutually exclusive with the existing `maxBytesInMemory`.
   
   I think it's confusing to have two different modes for the same parameter, and there's no indication in the property name that it can operate in a percentage-based mode. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org