You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "CodePrometheus (via GitHub)" <gi...@apache.org> on 2024/03/03 10:37:57 UTC
[PR] Add hierarchy for Pulsar [skywalking]
CodePrometheus opened a new pull request, #11971:
URL: https://github.com/apache/skywalking/pull/11971
Add hierarchy for Pulsar
<!--
β οΈ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist π ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== π Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes https://github.com/apache/skywalking/issues/11941.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add hierarchy for Pulsar [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #11971:
URL: https://github.com/apache/skywalking/pull/11971#issuecomment-1983410624
Please resolve the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add hierarchy for Pulsar [skywalking]
Posted by "peachisai (via GitHub)" <gi...@apache.org>.
peachisai commented on PR #11971:
URL: https://github.com/apache/skywalking/pull/11971#issuecomment-1982555518
Due to the difficulty of building the IP:port form relationship with the Pulsar-cluster ,I suggest adjusting local hosts to accommodate the Pulsar-cluster name If Pulsar java plugin report the address name as I suppose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add hierarchy for Pulsar [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #11971:
URL: https://github.com/apache/skywalking/pull/11971#issuecomment-1977690891
@CodePrometheus Please follow the above review and resolve the conflicting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add hierarchy for Pulsar [skywalking]
Posted by "CodePrometheus (via GitHub)" <gi...@apache.org>.
CodePrometheus commented on PR #11971:
URL: https://github.com/apache/skywalking/pull/11971#issuecomment-1983148923
> Due to the difficulty of building the IP:port format relationship with the Pulsar-cluster ,I suggest adjusting local hosts to accommodate the Pulsar-cluster name If Pulsar java plugin report the address name as I suppose
It works, @peachisai Youβre a genius! Very thanks~
<img width="477" alt="image" src="https://github.com/apache/skywalking/assets/66550292/2dcadb83-d1aa-4cc2-946c-ecd46835f383">
And I have an idea, is it possible to declare an empty custom key in auto-matching-rules, such as `custom: ""`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add hierarchy for Pulsar [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #11971:
URL: https://github.com/apache/skywalking/pull/11971#issuecomment-1979879723
From what I saw, your V-MQ is using IP:port which is provided by the agent plugin, meanwhile, server monitoring is using service name in k8s or something similar. You build the hierarchy rules, you need to make sure whey are aligned and the rules follow the setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add hierarchy for Pulsar [skywalking]
Posted by "CodePrometheus (via GitHub)" <gi...@apache.org>.
CodePrometheus commented on PR #11971:
URL: https://github.com/apache/skywalking/pull/11971#issuecomment-1979277564
Sorry, I've been busy with work lately. The showcase is in progress, and local test is as shown below, but the `service_hierarchy_relation` does not seem to be related to Virtual-MQ and Pulsar-cluster now, I'm still trying to figure it out, If teachers have any suggestions please let me know, thanks very much.
<img width="500" alt="image" src="https://github.com/apache/skywalking/assets/66550292/22d60205-9852-4b72-89d0-79a81f53f726">
<img width="500" alt="image" src="https://github.com/apache/skywalking/assets/66550292/386e1cb4-5a50-47bf-baed-8a0c35df00a5">
<img width="500" alt="image" src="https://github.com/apache/skywalking/assets/66550292/896943f6-ad71-4168-b4cf-2e23344d5ba4">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add hierarchy for Pulsar [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #11971:
URL: https://github.com/apache/skywalking/pull/11971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org