[jira] [Commented] (PHOENIX-2357) Prevent queries from failing because of scanners running into lease expiration

["James Taylor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995522#comment-14995522 ] 

James Taylor commented on PHOENIX-2357:
---------------------------------------

Patch looks very good, [~samarthjain]. One thing we need to consider (at least in the 0.98 branch) is that we need to have runtime support for HBase versions older than 0.98.14. For this, I think you'll need to define a kind of SPI with the implementation used being determined by the HBase version. For the pre 0.98.14, the implementation would be a bunch of noops. The SPI would include the creation and population of the LinkedBlockingQueue, the getScanners() method, and the scheduling of the task to renew the lease.

Also, the follow up work to no longer use the ChunkedResultIterator and SpoolingResultIterator would need to be conditional on the HBase version too.

Another possibility is that we only commit this to master and have it only in our 1.1 release. But make sure to check when this functionality became available in 1.1 (I seem to remember it's been in 1.1 from the beginning).


> Prevent queries from failing because of scanners running into lease expiration
> ------------------------------------------------------------------------------
>
>                 Key: PHOENIX-2357
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2357
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-2357_wip.patch, PHOENIX-2357_wip2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)