[Impala-ASF-CR] IMPALA-11926: Only loading Avro schema in LocalFsTable if the format is Avro

["Raghav Jindal (Code Review)" <ge...@cloudera.org>]

Hello Riza Suminto, Jason Fehr, Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23801

to look at the new patch set (#2).

Change subject: IMPALA-11926: Only loading Avro schema in LocalFsTable if the format is Avro
......................................................................

IMPALA-11926: Only loading Avro schema in LocalFsTable if the format is Avro

In local catalog mode LocalFsTable was always trying to load the Avro
schema if the avro.schema.url table property was present, even when the
table format was not Avro. This made tables unloadable if the URL was
invalid even when the table had no Avro data.

This is a regression from legacy catalog mode where
HdfsTable.setAvroSchema() only loads the Avro schema if the table
format is Avro or if there are any Avro partitions.

This change moves the loadAvroSchema() call inside the isAvroFormat() if
condition check, matching the legacy behavior. Avro schemas for Avro
partitions in mixed-format tables are still handled correctly in the
toTHdfsTable().

Testing: Added LocalCatalogTest.testNonAvroTableWithInvalidAvroSchemaUrl
and TestAvroSchemaResolution.test_non_avro_table_with_avro_schema_url.

Change-Id: I202665f978401894a1c837293529c06fa4270985
Made-with: Cursor
---
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
M tests/query_test/test_avro_schema_resolution.py
3 files changed, 53 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/23801/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I202665f978401894a1c837293529c06fa4270985
Gerrit-Change-Number: 23801
Gerrit-PatchSet: 2
Gerrit-Owner: Raghav Jindal <ra...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Raghav Jindal <ra...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>