You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by lh...@apache.org on 2021/09/11 10:59:41 UTC
[pulsar] branch master updated: Remove unnecessary creation of
JsonParser object per deprecation doc (#12008)
This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 04ee81f Remove unnecessary creation of JsonParser object per deprecation doc (#12008)
04ee81f is described below
commit 04ee81fd1851dee51080c2c27e9ec652722daf09
Author: Michael Marshall <mi...@datastax.com>
AuthorDate: Sat Sep 11 05:58:58 2021 -0500
Remove unnecessary creation of JsonParser object per deprecation doc (#12008)
---
.../main/java/org/apache/pulsar/client/impl/schema/SchemaUtils.java | 3 +--
.../src/main/java/org/apache/pulsar/functions/LocalRunner.java | 2 +-
.../java/org/apache/pulsar/proxy/server/ProxyAuthenticationTest.java | 3 +--
3 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/pulsar-common/src/main/java/org/apache/pulsar/client/impl/schema/SchemaUtils.java b/pulsar-common/src/main/java/org/apache/pulsar/client/impl/schema/SchemaUtils.java
index 9843e63..9747fb8 100644
--- a/pulsar-common/src/main/java/org/apache/pulsar/client/impl/schema/SchemaUtils.java
+++ b/pulsar-common/src/main/java/org/apache/pulsar/client/impl/schema/SchemaUtils.java
@@ -301,8 +301,7 @@ public final class SchemaUtils {
}
public static JsonObject toJsonObject(String json) {
- JsonParser parser = new JsonParser();
- return parser.parse(json).getAsJsonObject();
+ return JsonParser.parseString(json).getAsJsonObject();
}
private static class SchemaInfoToStringAdapter implements JsonSerializer<SchemaInfo> {
diff --git a/pulsar-functions/localrun/src/main/java/org/apache/pulsar/functions/LocalRunner.java b/pulsar-functions/localrun/src/main/java/org/apache/pulsar/functions/LocalRunner.java
index d672b4b..651523e 100644
--- a/pulsar-functions/localrun/src/main/java/org/apache/pulsar/functions/LocalRunner.java
+++ b/pulsar-functions/localrun/src/main/java/org/apache/pulsar/functions/LocalRunner.java
@@ -547,7 +547,7 @@ public class LocalRunner implements AutoCloseable {
for (index = 0; index < futures.length; ++index) {
String json = futures[index].get();
Gson gson = new GsonBuilder().setPrettyPrinting().create();
- log.info(gson.toJson(new JsonParser().parse(json)));
+ log.info(gson.toJson(JsonParser.parseString(json)));
}
} catch (TimeoutException | InterruptedException | ExecutionException e) {
log.error("Could not get status from all local instances");
diff --git a/pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyAuthenticationTest.java b/pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyAuthenticationTest.java
index 550aad4..2e74995 100644
--- a/pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyAuthenticationTest.java
+++ b/pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyAuthenticationTest.java
@@ -143,8 +143,7 @@ public class ProxyAuthenticationTest extends ProducerConsumerBase {
commandData = authData.getHttpHeader("BasicAuthentication");
}
- JsonParser parser = new JsonParser();
- JsonObject element = parser.parse(commandData).getAsJsonObject();
+ JsonObject element = JsonParser.parseString(commandData).getAsJsonObject();
long expiryTimeInMillis = Long.parseLong(element.get("expiryTime").getAsString());
long currentTimeInMillis = System.currentTimeMillis();
if (expiryTimeInMillis < currentTimeInMillis) {