You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/07/01 08:38:06 UTC
[GitHub] [kylin] codecov-io edited a comment on issue #681: KYLIN-4039,
fix ZK distributed lock may not release lock
codecov-io edited a comment on issue #681: KYLIN-4039, fix ZK distributed lock may not release lock
URL: https://github.com/apache/kylin/pull/681#issuecomment-500699377
# [Codecov](https://codecov.io/gh/apache/kylin/pull/681?src=pr&el=h1) Report
> Merging [#681](https://codecov.io/gh/apache/kylin/pull/681?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/6f12aaf5c62bfb10e2b3acf28520e259fce1a7a2?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `39.02%`.
[](https://codecov.io/gh/apache/kylin/pull/681?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #681 +/- ##
============================================
+ Coverage 25.72% 25.78% +0.06%
- Complexity 6017 6037 +20
============================================
Files 1386 1392 +6
Lines 82708 82808 +100
Branches 11599 11603 +4
============================================
+ Hits 21273 21352 +79
- Misses 59384 59401 +17
- Partials 2051 2055 +4
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/681?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...java/org/apache/kylin/job/util/ThrowableUtils.java](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi91dGlsL1Rocm93YWJsZVV0aWxzLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ck/zookeeper/exception/ZkAcquireLockException.java](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9leGNlcHRpb24vWmtBY3F1aXJlTG9ja0V4Y2VwdGlvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../lock/zookeeper/exception/ZkPeekLockException.java](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9leGNlcHRpb24vWmtQZWVrTG9ja0V4Y2VwdGlvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...keeper/exception/ZkPeekLockInterruptException.java](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9leGNlcHRpb24vWmtQZWVrTG9ja0ludGVycnVwdEV4Y2VwdGlvbi5qYXZh) | `20% <20%> (ø)` | `1 <1> (?)` | |
| [...per/exception/ZkReleaseLockInterruptException.java](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9leGNlcHRpb24vWmtSZWxlYXNlTG9ja0ludGVycnVwdEV4Y2VwdGlvbi5qYXZh) | `20% <20%> (ø)` | `1 <1> (?)` | |
| [...ck/zookeeper/exception/ZkReleaseLockException.java](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9leGNlcHRpb24vWmtSZWxlYXNlTG9ja0V4Y2VwdGlvbi5qYXZh) | `20% <20%> (ø)` | `1 <1> (?)` | |
| [...n/job/lock/zookeeper/ZookeeperDistributedLock.java](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9ab29rZWVwZXJEaXN0cmlidXRlZExvY2suamF2YQ==) | `54.67% <61.76%> (+54.67%)` | `18 <5> (+18)` | :arrow_up: |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | |
| [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
| ... and [6 more](https://codecov.io/gh/apache/kylin/pull/681/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/681?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/681?src=pr&el=footer). Last update [6f12aaf...22fe649](https://codecov.io/gh/apache/kylin/pull/681?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services