You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "T Jake Luciani (JIRA)" <ji...@apache.org> on 2015/07/14 05:59:05 UTC
[jira] [Updated] (CASSANDRA-9795) Fix cqlsh dtests on windows
[ https://issues.apache.org/jira/browse/CASSANDRA-9795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-9795:
--------------------------------------
Description:
There are a number of portability problems with python on win32 as I've learned over the past few days.
* Our use of multiprocess is broken in cqlsh for windows.
https://docs.python.org/2/library/multiprocessing.html#multiprocessing-programming
The code was passing self to the sub-process which on windows must be pickleable (it's not). So I refactored to be a class which is initialized in the parent.
Also, when the windows process starts it needs to load our cqlsh as a module. So I moved cqlsh -> cqlsh.py and added a tiny wrapper for bin/cqlsh
* Our use of strftime is broken on windows
The default timezone information %z in strftime isn't valid on windows. I added code to the date format parser in C* to support windows timezone labels.
* We have a number of file access issues in dtest
* csv import/export is broken on windows and requires all file be opened with mode 'wb' or 'rb'
http://stackoverflow.com/questions/1170214/pythons-csv-writer-produces-wrong-line-terminator/1170297#1170297
* CCM's use of popen required the univeral_newline=True flag to work on windows
was:
There are a number of portability problems with python on win32 as I've learned over the past few days.
* Our use of multiprocess is broken in cqlsh for windows.
https://docs.python.org/2/library/multiprocessing.html#multiprocessing-programming
The code was passing self to the sub-process which on windows must be pickleable (it's not). So I refactored to be a class which is initialized in the parent.
* Our use of strftime is broken on windows
The default timezone information %z in strftime isn't valid on windows. I added code to the date format parser in C* to support windows timezone labels.
* We have a number of file access issues in dtest
* csv import/export is broken on windows and requires all file be opened with mode 'wb' or 'rb'
http://stackoverflow.com/questions/1170214/pythons-csv-writer-produces-wrong-line-terminator/1170297#1170297
* CCM's use of popen required the univeral_newline=True flag to work on windows
> Fix cqlsh dtests on windows
> ---------------------------
>
> Key: CASSANDRA-9795
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9795
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: T Jake Luciani
> Assignee: T Jake Luciani
> Fix For: 2.2.x
>
>
> There are a number of portability problems with python on win32 as I've learned over the past few days.
> * Our use of multiprocess is broken in cqlsh for windows.
> https://docs.python.org/2/library/multiprocessing.html#multiprocessing-programming
> The code was passing self to the sub-process which on windows must be pickleable (it's not). So I refactored to be a class which is initialized in the parent.
> Also, when the windows process starts it needs to load our cqlsh as a module. So I moved cqlsh -> cqlsh.py and added a tiny wrapper for bin/cqlsh
> * Our use of strftime is broken on windows
> The default timezone information %z in strftime isn't valid on windows. I added code to the date format parser in C* to support windows timezone labels.
> * We have a number of file access issues in dtest
> * csv import/export is broken on windows and requires all file be opened with mode 'wb' or 'rb'
>
> http://stackoverflow.com/questions/1170214/pythons-csv-writer-produces-wrong-line-terminator/1170297#1170297
> * CCM's use of popen required the univeral_newline=True flag to work on windows
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)