You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/08/25 06:48:33 UTC

[GitHub] [mynewt-nimble] sjanc opened a new pull request #1012: nimble/host: Sync sending Host Number of Completed Packets command

sjanc opened a new pull request #1012:
URL: https://github.com/apache/mynewt-nimble/pull/1012


   Host Number of Completed Packets command is special as it doesn't
   generate status event and thus is not send with ble_hs_hci_cmd_tx.
   
   We should stil sync sending it with ble_hs_hci_cmd_tx() though to
   avoid requesting more than one command buffer from HCI transport
   (which may not be able to provide more).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #1012: nimble/host: Sync sending Host Number of Completed Packets command

Posted by GitBox <gi...@apache.org>.
rymanluk commented on a change in pull request #1012:
URL: https://github.com/apache/mynewt-nimble/pull/1012#discussion_r697223359



##########
File path: nimble/host/src/ble_hs_flow.c
##########
@@ -91,11 +91,17 @@ ble_hs_flow_tx_num_comp_pkts(void)
             /* The host-number-of-completed-packets command does not elicit a
              * response from the controller, so don't use the normal blocking
              * HCI API when sending it.
+             *
+             * We stil use ble_hs_hci_lock() though to sync with
+             * ble_hs_hci_cmd_tx() and don't request more than one command
+             * buffer from HCI ransport
              */
+            ble_hs_hci_lock();
             rc = ble_hs_hci_cmd_send_buf(

Review comment:
       what about creating ble_hs_hci_cmd_tx_no_rsp() ?
   Then ble_hs_hci_lock/unlock could stay state in ble_hs_hci.c
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-nimble] sjanc merged pull request #1012: nimble/host: Sync sending Host Number of Completed Packets command

Posted by GitBox <gi...@apache.org>.
sjanc merged pull request #1012:
URL: https://github.com/apache/mynewt-nimble/pull/1012


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #1012: nimble/host: Sync sending Host Number of Completed Packets command

Posted by GitBox <gi...@apache.org>.
rymanluk commented on a change in pull request #1012:
URL: https://github.com/apache/mynewt-nimble/pull/1012#discussion_r697223359



##########
File path: nimble/host/src/ble_hs_flow.c
##########
@@ -91,11 +91,17 @@ ble_hs_flow_tx_num_comp_pkts(void)
             /* The host-number-of-completed-packets command does not elicit a
              * response from the controller, so don't use the normal blocking
              * HCI API when sending it.
+             *
+             * We stil use ble_hs_hci_lock() though to sync with
+             * ble_hs_hci_cmd_tx() and don't request more than one command
+             * buffer from HCI ransport
              */
+            ble_hs_hci_lock();
             rc = ble_hs_hci_cmd_send_buf(

Review comment:
       what about creating ble_hs_hci_cmd_tx_no_rsp() ?
   Then ble_hs_hci_lock/unlock could stay static in ble_hs_hci.c
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org