You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/09/10 05:27:32 UTC
[jira] Created: (HBASE-2977) Refactor HMaster command line tool
into a new class
Refactor HMaster command line tool into a new class
---------------------------------------------------
Key: HBASE-2977
URL: https://issues.apache.org/jira/browse/HBASE-2977
Project: HBase
Issue Type: Task
Components: master
Affects Versions: 0.90.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
The whole main() thing inside of HMaster is a bit messy. I'd like to refactor it to a new class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2977) Refactor HMaster command line tool
into a new class
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907879#action_12907879 ]
HBase Review Board commented on HBASE-2977:
-------------------------------------------
Message from: stack@duboce.net
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/811/#review1145
-----------------------------------------------------------
Ship it!
+1
One minor item below -- take it or leave it
src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
<http://review.cloudera.org/r/811/#comment3947>
Suggest MasterCommandLine rather than H* (I hate the 'H' in front of everything)
- stack
> Refactor HMaster command line tool into a new class
> ---------------------------------------------------
>
> Key: HBASE-2977
> URL: https://issues.apache.org/jira/browse/HBASE-2977
> Project: HBase
> Issue Type: Task
> Components: master
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
>
> The whole main() thing inside of HMaster is a bit messy. I'd like to refactor it to a new class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2977) Refactor HMaster command line tool
into a new class
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907899#action_12907899 ]
Todd Lipcon commented on HBASE-2977:
------------------------------------
Oh, forgot to say that I stuck with HMasterCommandLine because the master is still called HMaster... it seems confusing to go halvsies here.
> Refactor HMaster command line tool into a new class
> ---------------------------------------------------
>
> Key: HBASE-2977
> URL: https://issues.apache.org/jira/browse/HBASE-2977
> Project: HBase
> Issue Type: Task
> Components: master
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.90.0
>
>
> The whole main() thing inside of HMaster is a bit messy. I'd like to refactor it to a new class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-2977) Refactor HMaster command line tool
into a new class
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon resolved HBASE-2977.
--------------------------------
Hadoop Flags: [Reviewed]
Fix Version/s: 0.90.0
Resolution: Fixed
Committed, thanks for review.
> Refactor HMaster command line tool into a new class
> ---------------------------------------------------
>
> Key: HBASE-2977
> URL: https://issues.apache.org/jira/browse/HBASE-2977
> Project: HBase
> Issue Type: Task
> Components: master
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.90.0
>
>
> The whole main() thing inside of HMaster is a bit messy. I'd like to refactor it to a new class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2977) Refactor HMaster command line tool
into a new class
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907874#action_12907874 ]
HBase Review Board commented on HBASE-2977:
-------------------------------------------
Message from: "Todd Lipcon" <to...@cloudera.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/811/
-----------------------------------------------------------
Review request for hbase, stack and Jonathan Gray.
Summary
-------
Straight refactor... more stuff like this coming, but this one should be noncontroversial.
This addresses bug HBASE-2977.
http://issues.apache.org/jira/browse/HBASE-2977
Diffs
-----
src/main/java/org/apache/hadoop/hbase/master/HMaster.java 2ac2c59
src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java PRE-CREATION
Diff: http://review.cloudera.org/r/811/diff
Testing
-------
Managed to start a master same as before.
Thanks,
Todd
> Refactor HMaster command line tool into a new class
> ---------------------------------------------------
>
> Key: HBASE-2977
> URL: https://issues.apache.org/jira/browse/HBASE-2977
> Project: HBase
> Issue Type: Task
> Components: master
> Affects Versions: 0.90.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
>
> The whole main() thing inside of HMaster is a bit messy. I'd like to refactor it to a new class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.