You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Liangyu Zhao via Review Board <no...@reviews.apache.org> on 2018/08/21 21:29:21 UTC
Review Request 68451: Windows: Parse version 2 schema 2 Docker image
manifest.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68451/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, Jie Yu, Joseph Wu, and Qian Zhang.
Bugs: MESOS-9159
https://issues.apache.org/jira/browse/MESOS-9159
Repository: mesos
Description
-------
Added support to parse V2S2 Docker image manifest
(https://docs.docker.com/registry/spec/manifest-v2-2/). Adopted the
validation code from patch 53850.
Diffs
-----
include/mesos/docker/spec.hpp 2879414dc42ffe633ac74b51e1bb116698c41162
include/mesos/docker/v2_2.hpp PRE-CREATION
include/mesos/docker/v2_2.proto PRE-CREATION
src/CMakeLists.txt a80b011bbd5c418ae66eb8dd7697d070168462bb
src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263
src/docker/spec.cpp 96fbf1f9cf1c2c4b2383607a97990f3a9156e6d9
Diff: https://reviews.apache.org/r/68451/diff/1/
Testing
-------
Thanks,
Liangyu Zhao
Re: Review Request 68451: Windows: Parse version 2 schema 2 Docker
image manifest.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68451/#review207800
-----------------------------------------------------------
Can you add unit test for the validate function?
- Jie Yu
On Aug. 21, 2018, 9:29 p.m., Liangyu Zhao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68451/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 9:29 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, Jie Yu, Joseph Wu, and Qian Zhang.
>
>
> Bugs: MESOS-9159
> https://issues.apache.org/jira/browse/MESOS-9159
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support to parse V2S2 Docker image manifest
> (https://docs.docker.com/registry/spec/manifest-v2-2/). Adopted the
> validation code from patch 53850.
>
>
> Diffs
> -----
>
> include/mesos/docker/spec.hpp 2879414dc42ffe633ac74b51e1bb116698c41162
> include/mesos/docker/v2_2.hpp PRE-CREATION
> include/mesos/docker/v2_2.proto PRE-CREATION
> src/CMakeLists.txt a80b011bbd5c418ae66eb8dd7697d070168462bb
> src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263
> src/docker/spec.cpp 96fbf1f9cf1c2c4b2383607a97990f3a9156e6d9
>
>
> Diff: https://reviews.apache.org/r/68451/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Liangyu Zhao
>
>
Re: Review Request 68451: Windows: Parse version 2 schema 2 Docker
image manifest.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68451/#review207799
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 21, 2018, 9:29 p.m., Liangyu Zhao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68451/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 9:29 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, Jie Yu, Joseph Wu, and Qian Zhang.
>
>
> Bugs: MESOS-9159
> https://issues.apache.org/jira/browse/MESOS-9159
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support to parse V2S2 Docker image manifest
> (https://docs.docker.com/registry/spec/manifest-v2-2/). Adopted the
> validation code from patch 53850.
>
>
> Diffs
> -----
>
> include/mesos/docker/spec.hpp 2879414dc42ffe633ac74b51e1bb116698c41162
> include/mesos/docker/v2_2.hpp PRE-CREATION
> include/mesos/docker/v2_2.proto PRE-CREATION
> src/CMakeLists.txt a80b011bbd5c418ae66eb8dd7697d070168462bb
> src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263
> src/docker/spec.cpp 96fbf1f9cf1c2c4b2383607a97990f3a9156e6d9
>
>
> Diff: https://reviews.apache.org/r/68451/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Liangyu Zhao
>
>
Re: Review Request 68451: Windows: Parse version 2 schema 2 Docker
image manifest.
Posted by Liangyu Zhao via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68451/
-----------------------------------------------------------
(Updated Aug. 23, 2018, 10:44 p.m.)
Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, Jie Yu, Joseph Wu, and Qian Zhang.
Changes
-------
Unit tests added
Bugs: MESOS-9159
https://issues.apache.org/jira/browse/MESOS-9159
Repository: mesos
Description
-------
Added support to parse V2S2 Docker image manifest
(https://docs.docker.com/registry/spec/manifest-v2-2/). Adopted the
validation code from patch 53850.
Diffs (updated)
-----
include/mesos/docker/spec.hpp 2879414dc42ffe633ac74b51e1bb116698c41162
include/mesos/docker/v2_2.hpp PRE-CREATION
include/mesos/docker/v2_2.proto PRE-CREATION
src/CMakeLists.txt a80b011bbd5c418ae66eb8dd7697d070168462bb
src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263
src/docker/spec.cpp 96fbf1f9cf1c2c4b2383607a97990f3a9156e6d9
src/tests/CMakeLists.txt fd01531451c101280fbbe6f7eb62342bb70c1464
src/tests/containerizer/docker_spec_tests.cpp 8f2fa4e6ce222a212e4f71d6cbe6f9e29f52a07a
Diff: https://reviews.apache.org/r/68451/diff/2/
Changes: https://reviews.apache.org/r/68451/diff/1-2/
Testing
-------
Thanks,
Liangyu Zhao