You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/21 20:40:59 UTC

[jira] [Commented] (BEAM-1022) TableNamespace should not use Java object equality when comparing windows

    [ https://issues.apache.org/jira/browse/BEAM-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684660#comment-15684660 ] 

ASF GitHub Bot commented on BEAM-1022:
--------------------------------------

GitHub user reuvenlax opened a pull request:

    https://github.com/apache/incubator-beam/pull/1400

    [BEAM-1022] Add test coverage for BigQuery.Write streaming

    There was no unit test coverage for BigQuery.Write in the case of unbounded input data. Add such unit-test coverage.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/reuvenlax/incubator-beam bigquery_testing

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1400.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1400
    
----
commit f1c5e5f5b9d842adc0774b3941adb56ca1605ab1
Author: Reuven Lax <re...@relax-macbookpro.roam.corp.google.com>
Date:   2016-11-17T18:57:41Z

    Add dead-letter support to BigQueryIO

commit 2e44b3ae9298edecd8269ad52aab23644bf38673
Author: Reuven Lax <re...@relax-macbookpro.roam.corp.google.com>
Date:   2016-11-19T22:28:10Z

    Add dead-letter support to BigQueryIO

commit fdc4794451fb0dcb8a13980fbdf5e64b58129045
Author: Reuven Lax <re...@relax-macbookpro.roam.corp.google.com>
Date:   2016-11-19T22:49:46Z

    Strip out non-testing changes.

commit 37f33d4b910edbf87cd3b37a9a5efc8cf9775e39
Author: Reuven Lax <re...@relax-macbookpro.roam.corp.google.com>
Date:   2016-11-19T23:09:10Z

    Remove dead code.

commit 835da28f8168b6d0d599bab3b55563f000313cb9
Author: Reuven Lax <re...@relax-macbookpro.roam.corp.google.com>
Date:   2016-11-21T20:30:29Z

    Add testing coverage for BigQuery streaming writes.

----


> TableNamespace should not use Java object equality when comparing windows
> -------------------------------------------------------------------------
>
>                 Key: BEAM-1022
>                 URL: https://issues.apache.org/jira/browse/BEAM-1022
>             Project: Beam
>          Issue Type: Bug
>          Components: beam-model
>    Affects Versions: 0.3.0-incubating
>            Reporter: Reuven Lax
>            Assignee: Thomas Groh
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)