You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2017/03/09 02:28:27 UTC

Review Request 57441: Turn Ranger deny policy & except condition blocks ON by default

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57441/
-----------------------------------------------------------

Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.


Bugs: RANGER-1436
    https://issues.apache.org/jira/browse/RANGER-1436


Repository: ranger


Description
-------

Currently Ranger admins have to do a service def update to turn on Deny Conditions block and Deny/Allow Except conditions in their Ranger install for resource based policies. But these are enabled by default for tag based policies. This change enforces consistency and turns this feature consistently ON by default for both resource and tag based policies.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java 7b3bd95 
  agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java dbdc935 
  security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefService.java 53b12d8 


Diff: https://reviews.apache.org/r/57441/diff/1/


Testing
-------

Tested with local VM.


Thanks,

Abhay Kulkarni


Re: Review Request 57441: Turn Ranger deny policy & except condition blocks ON by default

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57441/#review173099
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On March 9, 2017, 2:28 a.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57441/
> -----------------------------------------------------------
> 
> (Updated March 9, 2017, 2:28 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1436
>     https://issues.apache.org/jira/browse/RANGER-1436
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently Ranger admins have to do a service def update to turn on Deny Conditions block and Deny/Allow Except conditions in their Ranger install for resource based policies. But these are enabled by default for tag based policies. This change enforces consistency and turns this feature consistently ON by default for both resource and tag based policies.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java 7b3bd95 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java dbdc935 
>   security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefService.java 53b12d8 
> 
> 
> Diff: https://reviews.apache.org/r/57441/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with local VM.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>