You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "KarboniteKream (via GitHub)" <gi...@apache.org> on 2023/05/25 06:09:57 UTC
[GitHub] [kafka] KarboniteKream opened a new pull request, #13762: MINOR: Do not print an empty line when no topics exist
KarboniteKream opened a new pull request, #13762:
URL: https://github.com/apache/kafka/pull/13762
When running `kafka-topics.sh --list`, the command will print an empty line if no topics exist. This can cause some confusion when running with `wc -l`, so it's better to make sure the number of lines is zero in such a case.
This was tested against a cluster with 0 and 1+ topics to make sure the output is correct.
### Committer Checklist (excluded from commit message)
- [x] Verify design and implementation
- [x] Verify test coverage and CI build status
- [x] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Do not print an empty line when no topics exist [kafka]
Posted by "KarboniteKream (via GitHub)" <gi...@apache.org>.
KarboniteKream commented on PR #13762:
URL: https://github.com/apache/kafka/pull/13762#issuecomment-1766335152
@divijvaidya @vamossagar12 I have rebased my PR now that #13201 has been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13762: MINOR: Do not print an empty line when no topics exist
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13762:
URL: https://github.com/apache/kafka/pull/13762#issuecomment-1716888561
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] KarboniteKream commented on pull request #13762: MINOR: Do not print an empty line when no topics exist
Posted by "KarboniteKream (via GitHub)" <gi...@apache.org>.
KarboniteKream commented on PR #13762:
URL: https://github.com/apache/kafka/pull/13762#issuecomment-1591027643
Sure, it's no problem for me to wait. I just wanted to confirm what you had in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13762: MINOR: Do not print an empty line when no topics exist
Posted by "vamossagar12 (via GitHub)" <gi...@apache.org>.
vamossagar12 commented on PR #13762:
URL: https://github.com/apache/kafka/pull/13762#issuecomment-1581049711
Thanks for the PR @KarboniteKream . I agree with Divij's statement above about existing client might break. Also, there is an ongoing effort to [modularize the core monolith module](https://issues.apache.org/jira/browse/KAFKA-14524) which also covers some of the tools related migration. As part of that, [TopicCommand is also covered ](https://issues.apache.org/jira/browse/KAFKA-14596) and there's an open PR for the same https://github.com/apache/kafka/pull/13201
Since your PR is against master, you might want to align your PR with that PR? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Do not print an empty line when no topics exist [kafka]
Posted by "KarboniteKream (via GitHub)" <gi...@apache.org>.
KarboniteKream commented on code in PR #13762:
URL: https://github.com/apache/kafka/pull/13762#discussion_r1362046167
##########
tools/src/main/java/org/apache/kafka/tools/TopicCommand.java:
##########
@@ -469,7 +469,7 @@ public void createTopic(CommandTopicPartition topic) throws Exception {
CreateTopicsResult createResult = adminClient.createTopics(Collections.singleton(newTopic),
new CreateTopicsOptions().retryOnQuotaViolation(false));
createResult.all().get();
- System.out.println("Created topic " + topic.name + ".");
+ System.out.println("Created topic " + topic.name.get() + ".");
Review Comment:
This was logging as `Created topic Optional[foobar].`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Do not print an empty line when no topics exist [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #13762: MINOR: Do not print an empty line when no topics exist
URL: https://github.com/apache/kafka/pull/13762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vamossagar12 commented on pull request #13762: MINOR: Do not print an empty line when no topics exist
Posted by "vamossagar12 (via GitHub)" <gi...@apache.org>.
vamossagar12 commented on PR #13762:
URL: https://github.com/apache/kafka/pull/13762#issuecomment-1591024476
> Sure, I understand the concerns.
>
> > you might want to align your PR with that PR?
>
> Do you mean waiting for that PR to get merged, then rebase my changes? Or add my change to that PR?
You could wait for the PR to get merged if that's ok to you. It's your call TBH :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Do not print an empty line when no topics exist [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13762:
URL: https://github.com/apache/kafka/pull/13762#issuecomment-2567257734
This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.
<p>
If you are having difficulty finding a reviewer, please reach out on the
[mailing list](https://kafka.apache.org/contact).
<p>
If this PR is no longer valid or desired, please feel free to close it. If no activity
occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Do not print an empty line when no topics exist [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13762:
URL: https://github.com/apache/kafka/pull/13762#issuecomment-2629226250
This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] KarboniteKream commented on pull request #13762: MINOR: Do not print an empty line when no topics exist
Posted by "KarboniteKream (via GitHub)" <gi...@apache.org>.
KarboniteKream commented on PR #13762:
URL: https://github.com/apache/kafka/pull/13762#issuecomment-1583888214
Sure, I understand the concerns.
> you might want to align your PR with that PR?
Do you mean waiting for that PR to get merged, then rebase my changes? Or add my change to that PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org