You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/09/29 03:09:47 UTC
Review Request 38835: Ignore SIGPIPE when finalizing libevent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38835/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-3540
https://issues.apache.org/jira/browse/MESOS-3540
Repository: mesos
Description
-------
This fixes a Broken Pipe after unblocking SIGPIPE.
Diffs
-----
3rdparty/libprocess/src/libevent.cpp 00e0f08dd99fa60a92c1730c7ec899f2f7f55676
Diff: https://reviews.apache.org/r/38835/diff/
Testing
-------
make check with libevent and ssl enabled.
Thanks,
Joris Van Remoortere
Re: Review Request 38835: Ignore SIGPIPE when finalizing libevent.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38835/#review100919
-----------------------------------------------------------
Ship it!
Thanks!
3rdparty/libprocess/src/libevent.cpp (line 121)
<https://reviews.apache.org/r/38835/#comment158181>
Would be nice to keep this outside the suppress block, since we set to true outside the supress block above.
- Ben Mahler
On Sept. 29, 2015, 1:46 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38835/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 1:46 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3540
> https://issues.apache.org/jira/browse/MESOS-3540
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This fixes a Broken Pipe after unblocking SIGPIPE.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/libevent.cpp 00e0f08dd99fa60a92c1730c7ec899f2f7f55676
>
> Diff: https://reviews.apache.org/r/38835/diff/
>
>
> Testing
> -------
>
> make check with libevent and ssl enabled.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 38835: Ignore SIGPIPE when finalizing libevent.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38835/
-----------------------------------------------------------
(Updated Sept. 29, 2015, 1:46 a.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-3540
https://issues.apache.org/jira/browse/MESOS-3540
Repository: mesos
Description
-------
This fixes a Broken Pipe after unblocking SIGPIPE.
Diffs (updated)
-----
3rdparty/libprocess/src/libevent.cpp 00e0f08dd99fa60a92c1730c7ec899f2f7f55676
Diff: https://reviews.apache.org/r/38835/diff/
Testing
-------
make check with libevent and ssl enabled.
Thanks,
Joris Van Remoortere