You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/17 10:52:35 UTC
[GitHub] [incubator-superset] kgabryje opened a new pull request #12095: feat: Metrics and Filters controls redesign
kgabryje opened a new pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Redesign Metrics and Filters controls according to design in https://www.figma.com/file/JWaGztdhZS0kS5ruG7x9tB/Control-Panel?node-id=195%3A36068
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
CC: @villebro @junlincc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-748204728
got it, i misunderstood. will get to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mihir174 edited a comment on pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
mihir174 edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747727943
Hey all, here are design revisions that I just discussed with @villebro and @junlincc to allow users to add saved metrics that are defined in the dataset - https://www.figma.com/file/JWaGztdhZS0kS5ruG7x9tB/Control-Panel?node-id=195%3A36068
<img width="1076" alt="Screen Shot 2020-12-17 at 1 56 57 PM" src="https://user-images.githubusercontent.com/64227069/102548591-bc527480-406f-11eb-9db7-5463bdbe8ee3.png">
Since there are 3 ways to add a metric, it would be confusing if 2 or more of these ways were accessed from the same set of controls. Having one tab per way of adding seems like the most intuitive solution.
@kgabryje
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud edited a comment on pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747936902
Hi, finally got a chance to test this locally. Some feedbacks on the UX:
1. The focus state outline highlight got cut off:
<img src="https://user-images.githubusercontent.com/335541/102589587-12510780-40c4-11eb-98d6-97565c0721a5.png" width="400">
2. The metric pills for pre-defined metrics should show metric definition, either in a info icon tooltip or when clicked:
<img src="https://user-images.githubusercontent.com/335541/102589867-8095ca00-40c4-11eb-8b93-b3226d597ff4.png" width="400">
3. @mihir174 what do you think of removing the "+" icon but always show the "Add metric" pill that is currently only used in the empty state. It's a little weird that two CTA living so close are basically doing the same thing.
4. Custom SQL tab shows an empty pair of braces when entered without any column selection:
<img src="https://user-images.githubusercontent.com/335541/102590493-863fdf80-40c5-11eb-9352-fed2bec2f78d.png" width="400">
5. Can we please add drag & drop to sort the metrics soon?
Not sure if these are "known limitations", but I hope it got addressed soon. since this is not behind a feature flag, we basically can't deploy if the feature is incomplete (Good thing is we don't have to ship for at least another two weeks!)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-748040425
1,2,4 yes. 3 not yet until @mihir174 gets back. π
5 out of scope for this phase, but yes
@ktmud thanks for the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mihir174 commented on pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
mihir174 commented on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747727943
Hey all, here are design revisions that I just discussed with @villebro and @junlincc to allow users to add saved metrics that are defined in the dataset - https://www.figma.com/file/JWaGztdhZS0kS5ruG7x9tB/Control-Panel?node-id=195%3A36068
<img width="1076" alt="Screen Shot 2020-12-17 at 1 56 57 PM" src="https://user-images.githubusercontent.com/64227069/102548591-bc527480-406f-11eb-9db7-5463bdbe8ee3.png">
Since there are 3 ways to add a metric, so it would be confusing if 2 or more of these ways were accessed from the same set of controls. Having one tab per way of adding seems like the most intuitive solution.
@kgabryje
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747557796
@kgabryje much better UI!! many thanks for making it happen!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#discussion_r545066622
##########
File path: superset-frontend/spec/javascripts/explore/components/MetricsControl_spec.jsx
##########
@@ -150,138 +153,52 @@ describe('MetricsControl', () => {
});
describe('onChange', () => {
- it('handles saved metrics being selected', () => {
- const { wrapper, onChange } = setup();
- const select = wrapper.find(Select);
- select.simulate('change', [{ metric_name: 'sum__value' }]);
+ it('handles creating a new metric', () => {
+ const { component, onChange } = setup();
+ component.instance().onNewMetric({ metric_name: 'sum__value' });
Review comment:
We probably need to add the capability of selecting a saved (=datasource) metrics in the "Simple" tab so that saved metrics show up in the columns dropdown, and when selected, it hides the "Aggregate" select. Or some other mechanism.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747399255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=h1) Report
> Merging [#12095](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=desc) (197f5da) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `4.30%`.
> The diff coverage is `64.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12095 +/- ##
==========================================
- Coverage 67.55% 63.25% -4.31%
==========================================
Files 959 964 +5
Lines 47154 47407 +253
Branches 4609 4630 +21
==========================================
- Hits 31857 29985 -1872
- Misses 15185 17239 +2054
- Partials 112 183 +71
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.75% <64.97%> (+0.08%)` | :arrow_up: |
| python | `63.54% <ΓΈ> (-0.77%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | `58.00% <0.00%> (-18.00%)` | :arrow_down: |
| [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `70.00% <33.33%> (-17.50%)` | :arrow_down: |
| [...ntend/src/explore/components/AdhocMetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY09wdGlvbi5qc3g=) | `58.82% <40.00%> (-34.93%)` | :arrow_down: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `60.97% <60.97%> (ΓΈ)` | |
| [...c/explore/components/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1BvcG92ZXJUcmlnZ2VyLnRzeA==) | `62.06% <62.06%> (ΓΈ)` | |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `84.21% <64.28%> (-5.45%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `62.09% <65.21%> (-15.58%)` | :arrow_down: |
| [...c/explore/components/AdhocFilterPopoverTrigger.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlclBvcG92ZXJUcmlnZ2VyLnRzeA==) | `69.23% <69.23%> (ΓΈ)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.29% <70.00%> (-7.03%)` | :arrow_down: |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
| ... and [215 more](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=footer). Last update [2302adb...197f5da](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747399255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=h1) Report
> Merging [#12095](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=desc) (197f5da) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `3.95%`.
> The diff coverage is `64.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12095 +/- ##
==========================================
- Coverage 67.55% 63.60% -3.96%
==========================================
Files 959 964 +5
Lines 47154 47407 +253
Branches 4609 4630 +21
==========================================
- Hits 31857 30153 -1704
- Misses 15185 17071 +1886
- Partials 112 183 +71
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.75% <64.97%> (+0.08%)` | :arrow_up: |
| python | `64.11% <ΓΈ> (-0.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | `58.00% <0.00%> (-18.00%)` | :arrow_down: |
| [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `70.00% <33.33%> (-17.50%)` | :arrow_down: |
| [...ntend/src/explore/components/AdhocMetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY09wdGlvbi5qc3g=) | `58.82% <40.00%> (-34.93%)` | :arrow_down: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `60.97% <60.97%> (ΓΈ)` | |
| [...c/explore/components/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1BvcG92ZXJUcmlnZ2VyLnRzeA==) | `62.06% <62.06%> (ΓΈ)` | |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `84.21% <64.28%> (-5.45%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `62.09% <65.21%> (-15.58%)` | :arrow_down: |
| [...c/explore/components/AdhocFilterPopoverTrigger.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlclBvcG92ZXJUcmlnZ2VyLnRzeA==) | `69.23% <69.23%> (ΓΈ)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.29% <70.00%> (-7.03%)` | :arrow_down: |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
| ... and [207 more](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=footer). Last update [2302adb...197f5da](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747399255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=h1) Report
> Merging [#12095](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=desc) (3a174c4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `4.00%`.
> The diff coverage is `64.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12095 +/- ##
==========================================
- Coverage 67.55% 63.54% -4.01%
==========================================
Files 959 964 +5
Lines 47154 47407 +253
Branches 4609 4630 +21
==========================================
- Hits 31857 30127 -1730
- Misses 15185 17097 +1912
- Partials 112 183 +71
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.74% <64.97%> (+0.07%)` | :arrow_up: |
| python | `64.03% <ΓΈ> (-0.28%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | `58.00% <0.00%> (-18.00%)` | :arrow_down: |
| [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `70.00% <33.33%> (-17.50%)` | :arrow_down: |
| [...ntend/src/explore/components/AdhocMetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY09wdGlvbi5qc3g=) | `58.82% <40.00%> (-34.93%)` | :arrow_down: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `60.97% <60.97%> (ΓΈ)` | |
| [...c/explore/components/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1BvcG92ZXJUcmlnZ2VyLnRzeA==) | `62.06% <62.06%> (ΓΈ)` | |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `84.21% <64.28%> (-5.45%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `62.09% <65.21%> (-15.58%)` | :arrow_down: |
| [...c/explore/components/AdhocFilterPopoverTrigger.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlclBvcG92ZXJUcmlnZ2VyLnRzeA==) | `69.23% <69.23%> (ΓΈ)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.29% <70.00%> (-7.03%)` | :arrow_down: |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
| ... and [215 more](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=footer). Last update [2302adb...197f5da](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747399255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=h1) Report
> Merging [#12095](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=desc) (197f5da) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `4.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12095 +/- ##
==========================================
- Coverage 67.55% 63.54% -4.02%
==========================================
Files 959 479 -480
Lines 47154 29494 -17660
Branches 4609 0 -4609
==========================================
- Hits 31857 18743 -13114
+ Misses 15185 10751 -4434
+ Partials 112 0 -112
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.54% <ΓΈ> (-0.77%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <0.00%> (-0.30%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `34.50% <0.00%> (-0.29%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.37% <0.00%> (-0.14%)` | :arrow_down: |
| ... and [482 more](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=footer). Last update [2302adb...197f5da](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747399255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=h1) Report
> Merging [#12095](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=desc) (b20d83b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `3.45%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12095 +/- ##
==========================================
- Coverage 67.55% 64.10% -3.46%
==========================================
Files 959 478 -481
Lines 47154 29460 -17694
Branches 4609 0 -4609
==========================================
- Hits 31857 18885 -12972
+ Misses 15185 10575 -4610
+ Partials 112 0 -112
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.10% <ΓΈ> (-0.21%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `34.50% <0.00%> (-0.29%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.33% <0.00%> (-0.27%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <0.00%> (-0.27%)` | :arrow_down: |
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <0.00%> (ΓΈ)` | |
| ... and [480 more](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=footer). Last update [2302adb...b20d83b](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747399255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=h1) Report
> Merging [#12095](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=desc) (b20d83b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `3.45%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12095 +/- ##
==========================================
- Coverage 67.55% 64.10% -3.46%
==========================================
Files 959 478 -481
Lines 47154 29460 -17694
Branches 4609 0 -4609
==========================================
- Hits 31857 18885 -12972
+ Misses 15185 10575 -4610
+ Partials 112 0 -112
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.10% <ΓΈ> (-0.21%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `34.50% <0.00%> (-0.29%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.33% <0.00%> (-0.27%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `91.24% <0.00%> (-0.27%)` | :arrow_down: |
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <0.00%> (ΓΈ)` | |
| ... and [480 more](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=footer). Last update [2302adb...b20d83b](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-748039646
Thank you for your comments @ktmud, I'll work on those
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud edited a comment on pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747936902
Hi, finally got a chance to test this locally. Some feedbacks on the UX:
1. The focus state outline highlight got cut off:
<img src="https://user-images.githubusercontent.com/335541/102589587-12510780-40c4-11eb-98d6-97565c0721a5.png" width="400">
2. The metric pills for pre-defined metrics should show metric definition, either in a info icon tooltip or when clicked:
<img src="https://user-images.githubusercontent.com/335541/102589867-8095ca00-40c4-11eb-8b93-b3226d597ff4.png" width="400">
3. @mihir174 what do you think of removing the "+" icon but always show the "Add metric" pill that is currently only used in the empty state. It's a little weird that two CTA living so close are basically doing the same thing.
4. Can we please add drag & drop to sort the metrics soon?
Not sure if these are "known limitations", but I hope it got addressed soon. since this is not behind a feature flag, we basically can't deploy if the feature is incomplete (Good thing is we don't have to ship for at least another two weeks!)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje edited a comment on pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
kgabryje edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-748039646
Thank you for your comments @ktmud, I'll work on those issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-748201016
Added some clarification for (5). This is basically about having full feature parity of #9627 which implements #7129.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#discussion_r545066622
##########
File path: superset-frontend/spec/javascripts/explore/components/MetricsControl_spec.jsx
##########
@@ -150,138 +153,52 @@ describe('MetricsControl', () => {
});
describe('onChange', () => {
- it('handles saved metrics being selected', () => {
- const { wrapper, onChange } = setup();
- const select = wrapper.find(Select);
- select.simulate('change', [{ metric_name: 'sum__value' }]);
+ it('handles creating a new metric', () => {
+ const { component, onChange } = setup();
+ component.instance().onNewMetric({ metric_name: 'sum__value' });
Review comment:
We probably need to add the capability of selecting a saved (=datasource) metric in the "Simple" tab so that saved metrics show up in the columns dropdown, and when selected, it hides the "Aggregate" select.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747399255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=h1) Report
> Merging [#12095](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=desc) (197f5da) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `4.05%`.
> The diff coverage is `64.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12095 +/- ##
==========================================
- Coverage 67.55% 63.50% -4.06%
==========================================
Files 959 964 +5
Lines 47154 47407 +253
Branches 4609 4630 +21
==========================================
- Hits 31857 30107 -1750
- Misses 15185 17117 +1932
- Partials 112 183 +71
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.75% <64.97%> (+0.08%)` | :arrow_up: |
| python | `63.96% <ΓΈ> (-0.35%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | `58.00% <0.00%> (-18.00%)` | :arrow_down: |
| [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `70.00% <33.33%> (-17.50%)` | :arrow_down: |
| [...ntend/src/explore/components/AdhocMetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY09wdGlvbi5qc3g=) | `58.82% <40.00%> (-34.93%)` | :arrow_down: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `60.97% <60.97%> (ΓΈ)` | |
| [...c/explore/components/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1BvcG92ZXJUcmlnZ2VyLnRzeA==) | `62.06% <62.06%> (ΓΈ)` | |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `84.21% <64.28%> (-5.45%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `62.09% <65.21%> (-15.58%)` | :arrow_down: |
| [...c/explore/components/AdhocFilterPopoverTrigger.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlclBvcG92ZXJUcmlnZ2VyLnRzeA==) | `69.23% <69.23%> (ΓΈ)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.29% <70.00%> (-7.03%)` | :arrow_down: |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
| ... and [212 more](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=footer). Last update [2302adb...197f5da](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747399255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=h1) Report
> Merging [#12095](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=desc) (197f5da) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `4.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12095 +/- ##
==========================================
- Coverage 67.55% 63.19% -4.37%
==========================================
Files 959 479 -480
Lines 47154 29479 -17675
Branches 4609 0 -4609
==========================================
- Hits 31857 18628 -13229
+ Misses 15185 10851 -4334
+ Partials 112 0 -112
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.19% <ΓΈ> (-1.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [503 more](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=footer). Last update [2302adb...197f5da](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#discussion_r544996373
##########
File path: superset-frontend/spec/javascripts/explore/components/AdhocFilterControl_spec.jsx
##########
@@ -21,14 +21,15 @@ import React from 'react';
import sinon from 'sinon';
import { shallow } from 'enzyme';
-import Select from 'src/components/Select';
import AdhocFilter, {
EXPRESSION_TYPES,
CLAUSES,
} from 'src/explore/AdhocFilter';
import AdhocFilterControl from 'src/explore/components/controls/AdhocFilterControl';
import AdhocMetric from 'src/explore/AdhocMetric';
import { AGGREGATES, OPERATORS } from 'src/explore/constants';
+import { supersetTheme } from '@superset-ui/core';
+import { LabelsContainer } from '../../../../src/explore/components/OptionControls';
Review comment:
nit:
```suggestion
import { LabelsContainer } from '.src/explore/components/OptionControls';
```
##########
File path: superset-frontend/spec/javascripts/explore/components/MetricsControl_spec.jsx
##########
@@ -150,138 +153,52 @@ describe('MetricsControl', () => {
});
describe('onChange', () => {
- it('handles saved metrics being selected', () => {
- const { wrapper, onChange } = setup();
- const select = wrapper.find(Select);
- select.simulate('change', [{ metric_name: 'sum__value' }]);
+ it('handles creating a new metric', () => {
+ const { component, onChange } = setup();
+ component.instance().onNewMetric({ metric_name: 'sum__value' });
Review comment:
We probably need not add the capability of selecting a saved (=datasource) metric in the "Simple" tab so that saved metrics show up in the columns dropdown, and when selected, it hides the "Aggregate" select.
##########
File path: superset-frontend/src/explore/components/controls/MetricsControl.jsx
##########
@@ -103,58 +109,25 @@ function coerceAdhocMetrics(value) {
});
}
-function getDefaultAggregateForColumn(column) {
- const { type } = column;
- if (typeof type !== 'string') {
- return AGGREGATES.COUNT;
- }
- if (type === '' || type === 'expression') {
- return AGGREGATES.SUM;
- }
- if (
- type.match(/.*char.*/i) ||
- type.match(/string.*/i) ||
- type.match(/.*text.*/i)
- ) {
- return AGGREGATES.COUNT_DISTINCT;
- }
- if (
- type.match(/.*int.*/i) ||
- type === 'LONG' ||
- type === 'DOUBLE' ||
- type === 'FLOAT'
- ) {
- return AGGREGATES.SUM;
- }
- if (type.match(/.*bool.*/i)) {
- return AGGREGATES.MAX;
- }
- if (type.match(/.*time.*/i)) {
- return AGGREGATES.COUNT;
- }
- if (type.match(/unknown/i)) {
- return AGGREGATES.COUNT;
- }
- return null;
-}
Review comment:
I wonder if we could still leverage this logic for setting the default aggregate if it's unset and the user chooses the column first (the usual case)?
##########
File path: superset-frontend/images/icons/fx.svg
##########
@@ -0,0 +1,21 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<svg width="16" height="11" viewBox="0 0 16 11" fill="none" xmlns="http://www.w3.org/2000/svg">
+<path fill-rule="evenodd" clip-rule="evenodd" d="M4.82355 4.0072L3.96417 8.04041C3.81118 8.76307 3.48891 9.35388 2.99738 9.81287C2.50584 10.2719 1.99966 10.5013 1.47882 10.5013C1.19236 10.5013 0.981588 10.4468 0.846497 10.3378C0.711405 10.2287 0.64386 10.0912 0.64386 9.92517C0.64386 9.7852 0.686177 9.6615 0.770813 9.55408C0.855449 9.44666 0.977518 9.39295 1.13702 9.39295C1.23794 9.39295 1.32664 9.41573 1.40314 9.4613C1.47963 9.50688 1.54718 9.56384 1.60577 9.6322C1.65135 9.68754 1.70262 9.76241 1.75958 9.85681C1.81655 9.95121 1.86619 10.0326 1.90851 10.101C2.15916 10.0814 2.37319 9.91215 2.5506 9.59314C2.72801 9.27413 2.88181 8.8184 3.01202 8.22595L3.91046 4.0072H2.95831L3.06085 3.56287H4.00323L4.07159 3.23084C4.14972 2.85323 4.27342 2.51306 4.44269 2.21033C4.61196 1.90759 4.80402 1.65043 5.01886 1.43884C5.23045 1.23051 5.47052 1.06694 5.73907 0.94812C6.00763 0.829304 6.2656 0.769897 6.513 0.769897C6.79946 0.769897 7.01023 0.824422 7.14532 0.933472C7.28042 1.04252 7.34796 1.18005 7.
34796 1.34607C7.34796 1.48604 7.30809 1.60974 7.22833 1.71716C7.14858 1.82459 7.02407 1.8783 6.8548 1.8783C6.75389 1.8783 6.666 1.85632 6.59113 1.81238C6.51626 1.76843 6.44952 1.71065 6.39093 1.63904C6.32583 1.55766 6.27374 1.48116 6.23468 1.40955C6.19562 1.33793 6.14679 1.25818 6.0882 1.17029C5.86358 1.18005 5.66502 1.32816 5.49249 1.61462C5.31997 1.90108 5.16372 2.37797 5.02374 3.04529L4.91632 3.56287H6.14191L6.03937 4.0072H4.82355ZM6.67739 5.89197C6.67739 4.42712 7.05174 3.23897 7.83299 2.20544H8.42706C7.84926 2.946 7.3976 4.51664 7.3976 5.89197C7.3976 7.27543 7.84519 8.842 8.42706 9.58256H7.83299C7.05174 8.54903 6.67739 7.36088 6.67739 5.89197ZM11.0841 6.68949H11.019L9.97736 8.34558H9.1839L10.6854 6.15239L9.16762 3.95919H10.0018L11.0434 5.59086H11.1085L12.138 3.95919H12.9315L11.4422 6.1239L12.9518 8.34558H12.1217L11.0841 6.68949ZM15.442 5.89604C15.442 7.36088 15.0677 8.54903 14.2864 9.58256H13.6924C14.2702 8.842 14.7218 7.27136 14.7218 5.89604C14.7218 4.51257 14.2742 2.946 13.69
24 2.20544H14.2864C15.0677 3.23897 15.442 4.42712 15.442 5.89604Z" fill="#323232"/>
+</svg>
Review comment:
Nit: `function_x.svg` or similar might be a more explicit name, as someone (=me π ) might think "effects" when seeing `fx.svg`
##########
File path: superset-frontend/src/explore/components/controls/AdhocFilterControl.jsx
##########
@@ -113,13 +124,14 @@ export default class AdhocFilterControl extends React.Component {
Object.keys(partitions.cols).length === 1
) {
const partitionColumn = partitions.cols[0];
- this.valueRenderer = adhocFilter => (
+ this.valueRenderer = (adhocFilter, index) => (
<AdhocFilterOption
adhocFilter={adhocFilter}
onFilterEdit={this.onFilterEdit}
options={this.state.options}
datasource={this.props.datasource}
partitionColumn={partitionColumn}
+ onRemoveFilter={() => this.onRemoveFilter(index)}
Review comment:
Should we add `key={index}` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747399255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=h1) Report
> Merging [#12095](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=desc) (3a174c4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `4.27%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12095 +/- ##
==========================================
- Coverage 67.55% 63.28% -4.28%
==========================================
Files 959 479 -480
Lines 47154 29492 -17662
Branches 4609 0 -4609
==========================================
- Hits 31857 18664 -13193
+ Misses 15185 10828 -4357
+ Partials 112 0 -112
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.28% <ΓΈ> (-1.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.22% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.63% <0.00%> (-3.26%)` | :arrow_down: |
| ... and [492 more](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=footer). Last update [2302adb...197f5da](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud edited a comment on pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747936902
Hi, finally got a chance to test this locally. Some feedbacks on the UX:
1. The focus state outline highlight got cut off:
<img src="https://user-images.githubusercontent.com/335541/102589587-12510780-40c4-11eb-98d6-97565c0721a5.png" width="400">
2. The metric pills for pre-defined metrics should show metric definition, either in a info icon tooltip or when clicked:
<img src="https://user-images.githubusercontent.com/335541/102589867-8095ca00-40c4-11eb-8b93-b3226d597ff4.png" width="400">
3. @mihir174 what do you think of removing the "+" icon but always show the "Add metric" pill that is currently only used in the empty state. It's a little weird that two CTA living so close are basically doing the same thing.
4. Custom SQL tab shows an empty brackets when entered without any column selection:
<img src="https://user-images.githubusercontent.com/335541/102590493-863fdf80-40c5-11eb-9352-fed2bec2f78d.png" width="400">
5. Can we please add drag & drop to sort the metrics soon?
Not sure if these are "known limitations", but I hope it got addressed soon. since this is not behind a feature flag, we basically can't deploy if the feature is incomplete (Good thing is we don't have to ship for at least another two weeks!)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#discussion_r544996373
##########
File path: superset-frontend/spec/javascripts/explore/components/AdhocFilterControl_spec.jsx
##########
@@ -21,14 +21,15 @@ import React from 'react';
import sinon from 'sinon';
import { shallow } from 'enzyme';
-import Select from 'src/components/Select';
import AdhocFilter, {
EXPRESSION_TYPES,
CLAUSES,
} from 'src/explore/AdhocFilter';
import AdhocFilterControl from 'src/explore/components/controls/AdhocFilterControl';
import AdhocMetric from 'src/explore/AdhocMetric';
import { AGGREGATES, OPERATORS } from 'src/explore/constants';
+import { supersetTheme } from '@superset-ui/core';
+import { LabelsContainer } from '../../../../src/explore/components/OptionControls';
Review comment:
nit:
```suggestion
import { LabelsContainer } from 'src/explore/components/OptionControls';
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zhaoyongjie commented on pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-748061044
(5) can be done together with drag and drop support in Explore.
@ktmud
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747399255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=h1) Report
> Merging [#12095](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=desc) (3a174c4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `4.22%`.
> The diff coverage is `64.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12095 +/- ##
==========================================
- Coverage 67.55% 63.33% -4.23%
==========================================
Files 959 964 +5
Lines 47154 47407 +253
Branches 4609 4630 +21
==========================================
- Hits 31857 30024 -1833
- Misses 15185 17200 +2015
- Partials 112 183 +71
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.74% <64.97%> (+0.07%)` | :arrow_up: |
| python | `63.68% <ΓΈ> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | `58.00% <0.00%> (-18.00%)` | :arrow_down: |
| [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `70.00% <33.33%> (-17.50%)` | :arrow_down: |
| [...ntend/src/explore/components/AdhocMetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY09wdGlvbi5qc3g=) | `58.82% <40.00%> (-34.93%)` | :arrow_down: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `60.97% <60.97%> (ΓΈ)` | |
| [...c/explore/components/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1BvcG92ZXJUcmlnZ2VyLnRzeA==) | `62.06% <62.06%> (ΓΈ)` | |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `84.21% <64.28%> (-5.45%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `62.09% <65.21%> (-15.58%)` | :arrow_down: |
| [...c/explore/components/AdhocFilterPopoverTrigger.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlclBvcG92ZXJUcmlnZ2VyLnRzeA==) | `69.23% <69.23%> (ΓΈ)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.29% <70.00%> (-7.03%)` | :arrow_down: |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
| ... and [217 more](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=footer). Last update [2302adb...197f5da](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747399255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=h1) Report
> Merging [#12095](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=desc) (3a174c4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `4.00%`.
> The diff coverage is `64.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12095 +/- ##
==========================================
- Coverage 67.55% 63.54% -4.01%
==========================================
Files 959 964 +5
Lines 47154 47407 +253
Branches 4609 4630 +21
==========================================
- Hits 31857 30127 -1730
- Misses 15185 17097 +1912
- Partials 112 183 +71
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.74% <64.97%> (+0.07%)` | :arrow_up: |
| python | `64.03% <ΓΈ> (-0.28%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | `58.00% <0.00%> (-18.00%)` | :arrow_down: |
| [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `70.00% <33.33%> (-17.50%)` | :arrow_down: |
| [...ntend/src/explore/components/AdhocMetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY09wdGlvbi5qc3g=) | `58.82% <40.00%> (-34.93%)` | :arrow_down: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `60.97% <60.97%> (ΓΈ)` | |
| [...c/explore/components/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1BvcG92ZXJUcmlnZ2VyLnRzeA==) | `62.06% <62.06%> (ΓΈ)` | |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `84.21% <64.28%> (-5.45%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `62.09% <65.21%> (-15.58%)` | :arrow_down: |
| [...c/explore/components/AdhocFilterPopoverTrigger.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlclBvcG92ZXJUcmlnZ2VyLnRzeA==) | `69.23% <69.23%> (ΓΈ)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.29% <70.00%> (-7.03%)` | :arrow_down: |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
| ... and [215 more](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=footer). Last update [2302adb...197f5da](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747399255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=h1) Report
> Merging [#12095](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=desc) (b20d83b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `4.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12095 +/- ##
==========================================
- Coverage 67.55% 63.42% -4.14%
==========================================
Files 959 478 -481
Lines 47154 29445 -17709
Branches 4609 0 -4609
==========================================
- Hits 31857 18675 -13182
+ Misses 15185 10770 -4415
+ Partials 112 0 -112
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.42% <ΓΈ> (-0.89%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.73% <0.00%> (-6.87%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [501 more](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=footer). Last update [2302adb...b20d83b](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747618369
This looks so nice. Can't wait to get rid of react-select!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud edited a comment on pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747936902
Hi, finally got a chance to test this locally. Some feedbacks on the UX:
1. The focus state outline highlight got cut off:
<img src="https://user-images.githubusercontent.com/335541/102589587-12510780-40c4-11eb-98d6-97565c0721a5.png" width="400">
2. The metric pills for pre-defined metrics should show metric definition, either in a info icon tooltip or when clicked:
<img src="https://user-images.githubusercontent.com/335541/102589867-8095ca00-40c4-11eb-8b93-b3226d597ff4.png" width="400">
3. @mihir174 what do you think of removing the "+" icon but always show the "Add metric" pill that is currently only used in the empty state. It's a little weird that two CTA living so close are basically doing the same thing.
4. Custom SQL tab shows an empty pair of braces when entered without any column selection:
<img src="https://user-images.githubusercontent.com/335541/102590493-863fdf80-40c5-11eb-9352-fed2bec2f78d.png" width="400">
5. Can we please add drag & drop to sort the order of selected metrics soon?
Not sure if these are "known limitations", but I hope it got addressed soon. since this is not behind a feature flag, we basically can't deploy if the feature is incomplete (Good thing is we don't have to ship for at least another two weeks!)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-748040425
1,2,4 yes. 3 not yet until @mihir174 gets back. π
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747399255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=h1) Report
> Merging [#12095](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=desc) (197f5da) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `4.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12095 +/- ##
==========================================
- Coverage 67.55% 63.49% -4.07%
==========================================
Files 959 479 -480
Lines 47154 29494 -17660
Branches 4609 0 -4609
==========================================
- Hits 31857 18727 -13130
+ Misses 15185 10767 -4418
+ Partials 112 0 -112
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.49% <ΓΈ> (-0.82%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.26% <0.00%> (-1.63%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.71% <0.00%> (-0.30%)` | :arrow_down: |
| ... and [484 more](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=footer). Last update [2302adb...197f5da](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747603583
@kgabryje during testing I noticed some strange behavior, some of which was actually present from before, like inconsistent conversion of simple filters to sql filters and labels and how the `isValid()` function deals with missing values, causing false positives. I have a follow up PR that's mostly done which makes more sense to open after this is merged. So I suggest merging this when you feel this is ready and has had some more review and I'll follow up with a PR to fix some of those inconsistencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747399255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=h1) Report
> Merging [#12095](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=desc) (b20d83b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `3.69%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12095 +/- ##
==========================================
- Coverage 67.55% 63.86% -3.70%
==========================================
Files 959 478 -481
Lines 47154 29460 -17694
Branches 4609 0 -4609
==========================================
- Hits 31857 18815 -13042
+ Misses 15185 10645 -4540
+ Partials 112 0 -112
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.86% <ΓΈ> (-0.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.90% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.97% <0.00%> (-2.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.75% <0.00%> (-1.85%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.44% <0.00%> (-1.84%)` | :arrow_down: |
| ... and [488 more](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=footer). Last update [2302adb...b20d83b](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747936902
Hi, finally got a chance to test this locally. Some feedbacks on the UX:
1. The focus state outline highlight got cut off:
<img src="https://user-images.githubusercontent.com/335541/102589587-12510780-40c4-11eb-98d6-97565c0721a5.png" width="400">
2. The metric pills for pre-defined metrics should show metric definition, either in a info icon tooltip or when clicked:
<img src="https://user-images.githubusercontent.com/335541/102589867-8095ca00-40c4-11eb-8b93-b3226d597ff4.png" width="400">
3. @mihir174 what do you think of removing the "+" icon but always show the "Add metric" pill that is currently only used in the empty state.
4. Can we please add drag & drop to sort the metrics soon?
Not sure if these are "known limitations", but I hope it got addressed soon. since this is not behind a feature flag, we basically can't deploy if the feature is incomplete (Good thing is we don't have to ship for at least another two weeks!)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12095: feat: Metrics and Filters controls redesign
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747399255
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=h1) Report
> Merging [#12095](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=desc) (3a174c4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `4.47%`.
> The diff coverage is `64.97%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12095 +/- ##
==========================================
- Coverage 67.55% 63.08% -4.48%
==========================================
Files 959 964 +5
Lines 47154 47405 +251
Branches 4609 4630 +21
==========================================
- Hits 31857 29904 -1953
- Misses 15185 17318 +2133
- Partials 112 183 +71
```
| Flag | Coverage Ξ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.74% <64.97%> (+0.07%)` | :arrow_up: |
| python | `63.28% <ΓΈ> (-1.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | `58.00% <0.00%> (-18.00%)` | :arrow_down: |
| [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `70.00% <33.33%> (-17.50%)` | :arrow_down: |
| [...ntend/src/explore/components/AdhocMetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY09wdGlvbi5qc3g=) | `58.82% <40.00%> (-34.93%)` | :arrow_down: |
| [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `60.97% <60.97%> (ΓΈ)` | |
| [...c/explore/components/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY1BvcG92ZXJUcmlnZ2VyLnRzeA==) | `62.06% <62.06%> (ΓΈ)` | |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `84.21% <64.28%> (-5.45%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `62.09% <65.21%> (-15.58%)` | :arrow_down: |
| [...c/explore/components/AdhocFilterPopoverTrigger.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlclBvcG92ZXJUcmlnZ2VyLnRzeA==) | `69.23% <69.23%> (ΓΈ)` | |
| [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=) | `80.29% <70.00%> (-7.03%)` | :arrow_down: |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <100.00%> (ΓΈ)` | |
| ... and [225 more](https://codecov.io/gh/apache/incubator-superset/pull/12095/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=footer). Last update [2302adb...197f5da](https://codecov.io/gh/apache/incubator-superset/pull/12095?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747734645
π
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on pull request #12095: feat(explore): metrics and filters controls redesign
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12095:
URL: https://github.com/apache/incubator-superset/pull/12095#issuecomment-747733328
we are temporarily losing the saved metrics which used to show in the Select Column dropdown. we will bring those back by implementing above design @mihir174 proposed ^^^^^ ASAP in a separate PR in the following week.
cc: @ktmud @graceguo-supercat @etr2460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org