[GitHub] [ozone] adoroszlai commented on a change in pull request #3035: HDDS-6252. Datanode Chunk Validator fails on encountering EC pipeline

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #3035:
URL: https://github.com/apache/ozone/pull/3035#discussion_r798494337



##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/DatanodeChunkValidator.java
##########
@@ -109,9 +107,7 @@ public Void call() throws Exception {
 
       } else {
         pipeline = pipelines
-            .filter(
-                p -> ReplicationConfig.getLegacyFactor(p.getReplicationConfig())
-                    == HddsProtos.ReplicationFactor.THREE)
+              .filter(p -> p.getReplicationConfig().getRequiredNodes() == 3)

Review comment:
       I copied this condition from the corresponding generator class:
   
   https://github.com/apache/ozone/blob/e47b6f0c35534270441307f0338ab8184d2e2fb5/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/DatanodeChunkGenerator.java#L127
   
   But searching for this fragment I found that the base class has a utility method for the same purpose.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org