You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Alex Herbert <al...@gmail.com> on 2022/05/26 15:13:00 UTC
Re: [ALL] components still using Travis
Continuing the thread about switching Travis to GitHub actions...
Commons RNG has been running travis and GH actions in parallel now for 6
weeks as an experiment.
Some PRs have been missed by Travis. The master branch continues to be
built for all commits. The latest PR was built but about 12 hours after the
push. In comparison GH actions has been very fast, often building within a
few minutes.
So Travis support is flaky for PRs and slower than GH. I propose to drop
travis for RNG and migrate the following multi-module math derived projects
to GH actions:
- Numbers
- Statistics
- Math
- Geometry
One item to note is that to obtain code coverage requires a switch from
coveralls to codecov. For RNG this could use a single aggregate jacoco
report as the multi-module project has an aggregator module for coverage
and javadoc reports. However the codecov documentation indicates that a
comma separated list of reports can be used. So as a test I will try and
configure this for the 11 modules we have in numbers.
This change will require redirection of the CI build status and coverage
badges in the README.md page for each module.
Alex
Re: [ALL] components still using Travis
Posted by Alex Herbert <al...@gmail.com>.
On Fri, 27 May 2022 at 13:04, Matt Juntunen <ma...@gmail.com>
wrote:
> +1 as well.
>
> Thanks, Alex! I have spent quite a bit of time refreshing the Travis
> build page over and over waiting for my builds to start, so this will
> be a welcome change :-)
>
I have added workflows to:
- Numbers
- Statistics
- Geometry
using a similar configuration to RNG.
All can build the main modules in JDK 8, 11, 17 with the default maven
goal. The examples modules have extra requirements. Note here that the
previous travis setup would only build the parent module for the examples,
i.e. no recursion into the actual modules. Thus the previous CI was not
actually building the examples. With the GH action the target directory can
be set to the examples directory and then maven will recursively build all
child example modules.
Geometry required a more lenient goal to build the examples. Spotbugs
failed locally with JDK 17 for the JMH module. Feel free to have a look and
see what you think.
Note that building the examples modules, especially JMH, in numbers,
statistics and rng also requires some tweaks. PMD is typically set to not
fail the build (or simply to disabled for JMH to ignore all the generated
files).
RNG and Numbers cannot build the examples with JDK 8 and so currently only
target JDK 11. Thus it works with the default goal. Under JDK 17 I think it
would fail for the javadoc. I plan to get it to build on JDK 17 in the
future as this often spots issues that JDK 11 javadoc will ignore.
I have not yet tackled Math as its travis config only ever used JDK 8.
There may be a lot of issues with JDK 11 and 17 so I am leaving that for
another day when I have had a chance to test locally.
The codecov configuration for multiple modules requires a single line list
of files. For unknown reasons a valid multi-line YAML entry in quotes does
not concatenate and strip whitespace as expected. I initially missed this
as it is not reported as invalid YAML. But the coverage reports only had
the first module present.
IIRC once the coverage has made a few submissions then codecov starts
building nice reports. URLs should be:
https://app.codecov.io/gh/apache/commons-geometry
https://app.codecov.io/gh/apache/commons-numbers
https://app.codecov.io/gh/apache/commons-statistics
https://app.codecov.io/gh/apache/commons-rng
Final note is that the GH actions typically take a few minutes to complete
after a push. Thus I could test setup very quickly and correct errors. When
all is running smoothly we can disable travis and update the build and
coverage badges in the README.md files.
Alex
Re: [ALL] components still using Travis
Posted by Matt Juntunen <ma...@gmail.com>.
+1 as well.
Thanks, Alex! I have spent quite a bit of time refreshing the Travis
build page over and over waiting for my builds to start, so this will
be a welcome change :-)
-Matt J
On Thu, May 26, 2022 at 3:55 PM Bruno Kinoshita <br...@gmail.com> wrote:
>
> +1
>
> Thanks Alex!
>
> On Fri, 27 May 2022, 3:13 am Alex Herbert, <al...@gmail.com> wrote:
>
> > Continuing the thread about switching Travis to GitHub actions...
> >
> > Commons RNG has been running travis and GH actions in parallel now for 6
> > weeks as an experiment.
> >
> > Some PRs have been missed by Travis. The master branch continues to be
> > built for all commits. The latest PR was built but about 12 hours after the
> > push. In comparison GH actions has been very fast, often building within a
> > few minutes.
> >
> > So Travis support is flaky for PRs and slower than GH. I propose to drop
> > travis for RNG and migrate the following multi-module math derived projects
> > to GH actions:
> >
> > - Numbers
> > - Statistics
> > - Math
> > - Geometry
> >
> > One item to note is that to obtain code coverage requires a switch from
> > coveralls to codecov. For RNG this could use a single aggregate jacoco
> > report as the multi-module project has an aggregator module for coverage
> > and javadoc reports. However the codecov documentation indicates that a
> > comma separated list of reports can be used. So as a test I will try and
> > configure this for the 11 modules we have in numbers.
> >
> > This change will require redirection of the CI build status and coverage
> > badges in the README.md page for each module.
> >
> > Alex
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [ALL] components still using Travis
Posted by Bruno Kinoshita <br...@gmail.com>.
+1
Thanks Alex!
On Fri, 27 May 2022, 3:13 am Alex Herbert, <al...@gmail.com> wrote:
> Continuing the thread about switching Travis to GitHub actions...
>
> Commons RNG has been running travis and GH actions in parallel now for 6
> weeks as an experiment.
>
> Some PRs have been missed by Travis. The master branch continues to be
> built for all commits. The latest PR was built but about 12 hours after the
> push. In comparison GH actions has been very fast, often building within a
> few minutes.
>
> So Travis support is flaky for PRs and slower than GH. I propose to drop
> travis for RNG and migrate the following multi-module math derived projects
> to GH actions:
>
> - Numbers
> - Statistics
> - Math
> - Geometry
>
> One item to note is that to obtain code coverage requires a switch from
> coveralls to codecov. For RNG this could use a single aggregate jacoco
> report as the multi-module project has an aggregator module for coverage
> and javadoc reports. However the codecov documentation indicates that a
> comma separated list of reports can be used. So as a test I will try and
> configure this for the 11 modules we have in numbers.
>
> This change will require redirection of the CI build status and coverage
> badges in the README.md page for each module.
>
> Alex
>