[jira] [Commented] (ROCKETMQ-161) Update runbroker.sh and runserver.sh to support user defined jvm memory flag

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996430#comment-15996430 ] 

ASF GitHub Bot commented on ROCKETMQ-161:
-----------------------------------------

Github user shroman commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/87
  
    @dongeforever Hmm, sorry I don't understand yet why `JAVA_OPTS` won't work. Can you please explain how/when it happens? :)


> Update runbroker.sh and runserver.sh to support user defined jvm memory flag
> ----------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-161
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-161
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: dongeforever
>            Assignee: dongeforever
>             Fix For: 4.1.0-incubating
>
>
> JVM mem flag is hard coded in runbroker.sh as follows:
> JAVA_OPT="${JAVA_OPT} -server -Xms8g -Xmx8g -Xmn4g"
> If one want to change such flag, he has to change the script, this is not friendly, especially in docker environment.
> Instead, it is able to use an environment variable to handle user defined flag, like:
> if [ -z $BROKER_MEM_OPS ]; then
>     BROKER_MEM_OPS =  "-Xms8g -Xmx8g -Xmn4g"
> fi 
> JAVA_OPT="${JAVA_OPT} -server $BROKER_MEM_OPS"



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)