You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by ch...@apache.org on 2007/08/15 16:51:59 UTC
svn commit: r566204 - /activemq/camel/trunk/etc/activemq-checkstyle.xml
Author: chirino
Date: Wed Aug 15 07:51:58 2007
New Revision: 566204
URL: http://svn.apache.org/viewvc?view=rev&rev=566204
Log:
lax some of the rules
Modified:
activemq/camel/trunk/etc/activemq-checkstyle.xml
Modified: activemq/camel/trunk/etc/activemq-checkstyle.xml
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/etc/activemq-checkstyle.xml?view=diff&rev=566204&r1=566203&r2=566204
==============================================================================
--- activemq/camel/trunk/etc/activemq-checkstyle.xml (original)
+++ activemq/camel/trunk/etc/activemq-checkstyle.xml Wed Aug 15 07:51:58 2007
@@ -57,7 +57,7 @@
<!-- Checks for Naming Conventions. -->
<!-- See http://checkstyle.sf.net/config_naming.html -->
<module name="ConstantName"/>
- <module name="LocalFinalVariableName"/>
+ <module name="LocalFinalVariableName"/>-->
<module name="LocalVariableName"/>
<module name="MemberName"/>
<module name="MethodName"/>
@@ -98,7 +98,7 @@
<!-- Checks for Size Violations. -->
<!-- See http://checkstyle.sf.net/config_sizes.html -->
<module name="AnonInnerLength">
- <property name="max" value="40"/>
+ <property name="max" value="200"/>
</module>
<module name="ExecutableStatementCount">
<property name="max" value="75"/>
@@ -136,7 +136,8 @@
<property name="tokens" value="COMMA, SEMI"/>
</module>
<module name="WhitespaceAround">
- <property name="tokens" value="ASSIGN, BAND, BAND_ASSIGN, BOR, BOR_ASSIGN, BSR, BSR_ASSIGN, BXOR, BXOR_ASSIGN, COLON, DIV, DIV_ASSIGN, EQUAL, GE, GT, LAND, LCURLY, LE, LITERAL_ASSERT, LITERAL_CATCH, LITERAL_DO, LITERAL_ELSE, LITERAL_FINALLY, LITERAL_FOR, LITERAL_IF, LITERAL_RETURN, LITERAL_SYNCHRONIZED, LITERAL_TRY, LITERAL_WHILE, LOR, LT, MINUS, MINUS_ASSIGN, MOD, MOD_ASSIGN, NOT_EQUAL, PLUS, PLUS_ASSIGN, QUESTION, RCURLY, SL, SLIST, SL_ASSIGN, SR, SR_ASSIGN, STAR, STAR_ASSIGN,TYPE_EXTENSION_AND"/>
+ <property name="tokens" value="ASSIGN, BAND, BAND_ASSIGN, BOR, BOR_ASSIGN, BSR, BSR_ASSIGN, BXOR, BXOR_ASSIGN, COLON, DIV, DIV_ASSIGN, EQUAL, GE, GT, LAND, LCURLY, LE, LITERAL_ASSERT, LITERAL_CATCH, LITERAL_DO, LITERAL_ELSE, LITERAL_FINALLY, LITERAL_FOR, LITERAL_IF, LITERAL_RETURN, LITERAL_SYNCHRONIZED, LITERAL_TRY, LITERAL_WHILE, LOR, LT, MINUS, MINUS_ASSIGN, MOD, MOD_ASSIGN, NOT_EQUAL, PLUS, PLUS_ASSIGN, QUESTION, SL, SLIST, SL_ASSIGN, SR, SR_ASSIGN, STAR, STAR_ASSIGN,TYPE_EXTENSION_AND"/>
+ <!-- <property name="tokens" value="ASSIGN, BAND, BAND_ASSIGN, BOR, BOR_ASSIGN, BSR, BSR_ASSIGN, BXOR, BXOR_ASSIGN, COLON, DIV, DIV_ASSIGN, EQUAL, GE, GT, LAND, LCURLY, LE, LITERAL_ASSERT, LITERAL_CATCH, LITERAL_DO, LITERAL_ELSE, LITERAL_FINALLY, LITERAL_FOR, LITERAL_IF, LITERAL_RETURN, LITERAL_SYNCHRONIZED, LITERAL_TRY, LITERAL_WHILE, LOR, LT, MINUS, MINUS_ASSIGN, MOD, MOD_ASSIGN, NOT_EQUAL, PLUS, PLUS_ASSIGN, QUESTION, RCURLY, SL, SLIST, SL_ASSIGN, SR, SR_ASSIGN, STAR, STAR_ASSIGN,TYPE_EXTENSION_AND"/>-->
</module>
@@ -148,9 +149,11 @@
<!-- Checks for blocks. You know, those {}'s -->
<!-- See http://checkstyle.sf.net/config_blocks.html -->
+ <!--
<module name="AvoidNestedBlocks">
<property name="allowInSwitchCase" value="true"/>
</module>
+ -->
<!-- We use alot of emply blocks.. they can be good too.
<module name="EmptyBlock">
<property name="option" value="text"/>
@@ -179,7 +182,7 @@
<module name="IllegalInstantiation"/>
<!--<module name="IllegalToken"/>-->
<!--<module name="IllegalTokenText"/>-->
- <module name="InnerAssignment"/>
+ <!--<module name="InnerAssignment"/>-->
<!--<module name="MagicNumber"/>-->
<module name="MissingSwitchDefault"/>
<!--module name="ModifiedControlVariable"/-->
@@ -192,7 +195,7 @@
<module name="NestedTryDepth">
<property name="max" value="8"/>
</module>
- <module name="SuperClone"/>
+ <!--<module name="SuperClone"/>-->
<module name="SuperFinalize"/>
<!--<module name="IllegalCatch"/>-->
<module name="IllegalThrows">
@@ -200,7 +203,9 @@
</module>
<!--<module name="RedundantThrows"/>-->
<module name="PackageDeclaration"/>
+ <!--
<module name="JUnitTestCase"/>
+ -->
<module name="ReturnCount">
<property name="max" value="20"/>
</module>
@@ -229,20 +234,22 @@
<!--<module name="DesignForExtension"/>-->
<module name="FinalClass"/>
<module name="HideUtilityClassConstructor"/>
+ <!-- We still do enum style interfaces
<module name="InterfaceIsType"/>
+ -->
<module name="MutableException"/>
<module name="ThrowsCount">
<property name="max" value="5"/>
</module>
+
+ <!-- Ah we do a fair bit of using a class like a struct.. so
+ we are not so strict on requirin encapsulation
<module name="VisibilityModifier">
<property name="protectedAllowed" value="true"/>
<property name="packageAllowed" value="true"/>
- <!-- this is needed for the resource injection unit tests. It will removed
- when private member inject is supported.
- -->
<property name="publicMemberPattern" value="resource[12].*"/>
</module>
-
+ -->
<!-- Metrics checks. -->