You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "yjshen (via GitHub)" <gi...@apache.org> on 2023/04/16 04:56:22 UTC

[GitHub] [arrow-rs] yjshen opened a new issue, #4095: Arrow compute kernel regards selection vector

yjshen opened a new issue, #4095:
URL: https://github.com/apache/arrow-rs/issues/4095

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for this feature, in addition to  the *what*)
   -->
   
   It would be great if the arrow compute kernel could regard a selection vector. Then users won't need to create slices over the existing arrays before applying computations with the compute kernel.
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   
   A set of new compute APIs that takes a selection vector as the second argument.
   
   For example:
   
   ```rust
   pub fn sum<T: ArrowNumericType>(array: &PrimitiveArray<T>, selection_vector: &BooleanArray) -> Option<T::Native>
   where
       T::Native: ArrowNativeTypeOp,
   {
   ```
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features you've considered.
   -->
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   
   https://github.com/apache/arrow-datafusion/pull/6003 as a use case where the selection vector would be beneficial.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] alamb commented on issue #4095: Arrow compute kernel regards selection vector

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #4095:
URL: https://github.com/apache/arrow-rs/issues/4095#issuecomment-1595001133

   `label_issue.py` automatically added labels {'arrow'} from #4393


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on issue #4095: Arrow compute kernel regards selection vector

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #4095:
URL: https://github.com/apache/arrow-rs/issues/4095#issuecomment-1510285967

   For primitives at least, I would expect a filter followed by the existing sum kernel to be very competitive, as it has been my experience that LLVM struggles to vectorise operations involving bitmasks.
   
   We should definitely benchmark any new kernels against this "naive" approach


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on issue #4095: Arrow compute kernel regards selection vector

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #4095:
URL: https://github.com/apache/arrow-rs/issues/4095#issuecomment-1591038807

   I'm going to close this as a duplicate of https://github.com/apache/arrow-rs/issues/3620


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold closed issue #4095: Arrow compute kernel regards selection vector

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #4095: Arrow compute kernel regards selection vector
URL: https://github.com/apache/arrow-rs/issues/4095


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org