You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/10/31 18:17:59 UTC
[GitHub] [accumulo] DomGarguilo opened a new pull request, #3058: Move DataTable errors to console to avoid alerts
DomGarguilo opened a new pull request, #3058:
URL: https://github.com/apache/accumulo/pull/3058
Closes #3057
This change makes DataTable errors get logged to console instead of creating many, spammy alerts on the page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on a diff in pull request #3058: Move DataTable errors to console to avoid alerts
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on code in PR #3058:
URL: https://github.com/apache/accumulo/pull/3058#discussion_r1009737522
##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/resources/js/ec.js:
##########
@@ -31,6 +31,10 @@ $(document).ready(function () {
if (sessionStorage.ecDetailsJSON === undefined) {
sessionStorage.ecDetailsJSON = JSON.stringify([]);
}
+
+ // display datatables errors in the console instead of in alerts
+ $.fn.dataTable.ext.errMode = 'throw';
Review Comment:
The other tables will create similar alerts when the scenario outlined in #3057 happens, so I think its best that it affects all of the tables in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3058: Move DataTable errors to console to avoid alerts
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on code in PR #3058:
URL: https://github.com/apache/accumulo/pull/3058#discussion_r1009731774
##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/resources/js/ec.js:
##########
@@ -31,6 +31,10 @@ $(document).ready(function () {
if (sessionStorage.ecDetailsJSON === undefined) {
sessionStorage.ecDetailsJSON = JSON.stringify([]);
}
+
+ // display datatables errors in the console instead of in alerts
+ $.fn.dataTable.ext.errMode = 'throw';
Review Comment:
This looks like a global parameter. Do we want to set this globally? Is this okay for other tables that might be displayed on the page (if there are any)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo merged pull request #3058: Move DataTable errors to console to avoid alerts
Posted by GitBox <gi...@apache.org>.
DomGarguilo merged PR #3058:
URL: https://github.com/apache/accumulo/pull/3058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org