You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/05/27 18:30:11 UTC
[GitHub] [lucene-solr] madrob opened a new pull request #1539: Fix typos in release wizard
madrob opened a new pull request #1539:
URL: https://github.com/apache/lucene-solr/pull/1539
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob merged pull request #1539: Fix typos in release wizard
Posted by GitBox <gi...@apache.org>.
madrob merged pull request #1539:
URL: https://github.com/apache/lucene-solr/pull/1539
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on a change in pull request #1539: Fix typos in release wizard
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #1539:
URL: https://github.com/apache/lucene-solr/pull/1539#discussion_r434833772
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -1491,13 +1496,13 @@ groups:
cmd: ant clean
- !Command
cmd: python3 -u dev-tools/scripts/addBackcompatIndexes.py --no-cleanup --temp-dir {{ temp_dir }} {{ release_version }} && git add lucene/backward-codecs/src/test/org/apache/lucene/index/
- logfile: add-bakccompat.log
+ logfile: add-backcompat.log
- !Command
- cmd: git diff
+ cmd: git diff --staged
comment: Check the git diff before committing
tee: true
- !Command
- cmd: git add -u . && git commit -m "Add back-compat indices for {{ release_version }}" && git push
+ cmd: git commit -m "Add back-compat indices for {{ release_version }}" && git push
Review comment:
Because you already do `git add` on line 1498.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org