[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #700: RFCLK refactor

[GitBox <gi...@apache.org>]

rymanluk commented on a change in pull request #700: RFCLK refactor
URL: https://github.com/apache/mynewt-nimble/pull/700#discussion_r358164916
 
 

 ##########
 File path: nimble/controller/src/ble_ll_scan.c
 ##########
 @@ -1519,30 +1520,28 @@ ble_ll_scan_event_proc(struct ble_npl_event *ev)
     now = os_cputime_get32();
 
     /* check current phy */
-    inside_window = check_phy_window(scanphy, now, &next_event_time, &dt, &win,
-                                     &scan_itvl);
+    inside_window = check_phy_window(scanphy, now, &dt, &timing);
+
+    /* timing.start_time is start time for *next* window */
 
 Review comment:
   I would move this comment to 1522, so it is clear that this comment is related to "check_phy_window" which is also setting next window.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services