You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/17 16:48:02 UTC
[GitHub] [airflow] owlphi opened a new pull request #13138: Fix insert_all in bigquery hook
owlphi opened a new pull request #13138:
URL: https://github.com/apache/airflow/pull/13138
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] owlphi commented on pull request #13138: Fix insert_all in bigquery hook
Posted by GitBox <gi...@apache.org>.
owlphi commented on pull request #13138:
URL: https://github.com/apache/airflow/pull/13138#issuecomment-750829957
Hi @turbaszek , @mik-laj ,
Could you help here please? I have create a PR to solved the issue and I am not sure what to do next. Is there any other alternatives to solve the issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] owlphi edited a comment on pull request #13138: Fix insert_all in bigquery hook
Posted by GitBox <gi...@apache.org>.
owlphi edited a comment on pull request #13138:
URL: https://github.com/apache/airflow/pull/13138#issuecomment-748588802
Hi @turbaszek
Thank you for reviewing my PR. I am not sure if I understood well, so I may need your help.
The issue is in the bigquery hook, not the operators.
I have compared the method **insert_rows** for the two version you mentioned: v2.0.0 vs v1.28.0. The logic seems the same:
https://github.com/googleapis/python-bigquery/blob/v1.28.0/google/cloud/bigquery/client.py#L2780-#L2840
https://github.com/googleapis/python-bigquery/blob/v2.0.0/google/cloud/bigquery/client.py#L2776-#L2836
If you could point it out where the different logic is, it will help me. Otherwise I am not sure the version 2.0.0 will fix the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] owlphi edited a comment on pull request #13138: Fix insert_all in bigquery hook
Posted by GitBox <gi...@apache.org>.
owlphi edited a comment on pull request #13138:
URL: https://github.com/apache/airflow/pull/13138#issuecomment-750829957
Hi @turbaszek , @mik-laj ,
Could you help here please? I have create a PR to solve the issue and I am not sure what to do next. Is there any other alternatives to solve the issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] owlphi edited a comment on pull request #13138: Fix insert_all in bigquery hook
Posted by GitBox <gi...@apache.org>.
owlphi edited a comment on pull request #13138:
URL: https://github.com/apache/airflow/pull/13138#issuecomment-750829957
Hi @turbaszek , @mik-laj ,
Could you help here please? I have create a PR to solve the issue and I am not sure what to do next. Is there any other alternative to solve the issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #13138: Fix insert_all in bigquery hook
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #13138:
URL: https://github.com/apache/airflow/pull/13138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] owlphi edited a comment on pull request #13138: Fix insert_all in bigquery hook
Posted by GitBox <gi...@apache.org>.
owlphi edited a comment on pull request #13138:
URL: https://github.com/apache/airflow/pull/13138#issuecomment-748588802
Hi @turbaszek
Thank you for reviewing my PR. I am not sure if I understood well, so I may need your help.
The issue is in the bigquery hook, not the operators.
I have compare the code **insert_rows** for the two version you mentioned: v2.0.0 vs v1.28.0. The logic seems the same:
https://github.com/googleapis/python-bigquery/blob/v1.28.0/google/cloud/bigquery/client.py#L2780-#L2840
https://github.com/googleapis/python-bigquery/blob/v2.0.0/google/cloud/bigquery/client.py#L2776-#L2836
If you could point it out where the different logic is, it will help me. Otherwise I am not sure the version 2.0.0 will fix the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] owlphi edited a comment on pull request #13138: Fix insert_all in bigquery hook
Posted by GitBox <gi...@apache.org>.
owlphi edited a comment on pull request #13138:
URL: https://github.com/apache/airflow/pull/13138#issuecomment-750829957
Hi @turbaszek , @mik-laj ,
Could you help here please? I have create a PR to solve the issue and I am not sure what to do next. Is there any other alternative to solve the issue or better solution than the one I propose?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] owlphi edited a comment on pull request #13138: Fix insert_all in bigquery hook
Posted by GitBox <gi...@apache.org>.
owlphi edited a comment on pull request #13138:
URL: https://github.com/apache/airflow/pull/13138#issuecomment-748588802
Hi @turbaszek
Thank you for reviewing my PR. I am not sure if I understood well, so I may need your help.
The issue is in the bigquery hook, not the operators.
I have compared the method **insert_rows** for the two version you mentioned: v2.0.0 vs v1.28.0. The logic seems the same:
https://github.com/googleapis/python-bigquery/blob/v1.28.0/google/cloud/bigquery/client.py#L2780-#L2840
https://github.com/googleapis/python-bigquery/blob/v2.0.0/google/cloud/bigquery/client.py#L2776-#L2836
If you could point it out where the different logic is, it will help me. Otherwise I am not sure the version 2.0.0 will fix the issue.
The changes I have proposed solved the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #13138: Fix insert_all in bigquery hook
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #13138:
URL: https://github.com/apache/airflow/pull/13138#issuecomment-748411983
I'm afraid that the problem is slightly different: we do not pin bigquery python library version. The operators should use version under 2.0.0, which has different logic:
https://github.com/googleapis/python-bigquery/blob/v1.28.0/google/cloud/bigquery/client.py
I know there are some plans to update all google operators to support 2.0.0 versions but for time being I would usggest pinning bigquery to 1.28.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] owlphi edited a comment on pull request #13138: Fix insert_all in bigquery hook
Posted by GitBox <gi...@apache.org>.
owlphi edited a comment on pull request #13138:
URL: https://github.com/apache/airflow/pull/13138#issuecomment-748588802
Hi @turbaszek
Thank you for reviewing my PR. I am not sure if I understood well, so I may need your help.
The issue is in the bigquery hook, not the operators.
I have compared the method **insert_rows** for the two version you mentioned: v2.0.0 vs v1.28.0. The logic seems the same:
https://github.com/googleapis/python-bigquery/blob/v1.28.0/google/cloud/bigquery/client.py#L2780-#L2840
https://github.com/googleapis/python-bigquery/blob/v2.0.0/google/cloud/bigquery/client.py#L2776-#L2836
If you could point it out where the different logic is, it will help me. Otherwise I am not sure the version 2.0.0 will fix the issue.
The changes that I have proposed and introduce in my PR solves the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] owlphi commented on pull request #13138: Fix insert_all in bigquery hook
Posted by GitBox <gi...@apache.org>.
owlphi commented on pull request #13138:
URL: https://github.com/apache/airflow/pull/13138#issuecomment-748588802
Hi @turbaszek
Thank you for reviewing my PR. I am not sure if I understood well, so I may need your help.
The issue is in the bigquery hook, not the operators.
I have compare the code **insert_rows** for the two version you mention: v2.0.0 vs v1.28.0. The logic seems the same:
https://github.com/googleapis/python-bigquery/blob/v1.28.0/google/cloud/bigquery/client.py#L2780-#L2840
https://github.com/googleapis/python-bigquery/blob/v2.0.0/google/cloud/bigquery/client.py#L2776-#L2836
If you could point it out where the different logic is, it will help me. Otherwise I am not sure the version 2.0.0 will fix the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] owlphi edited a comment on pull request #13138: Fix insert_all in bigquery hook
Posted by GitBox <gi...@apache.org>.
owlphi edited a comment on pull request #13138:
URL: https://github.com/apache/airflow/pull/13138#issuecomment-748588802
Hi @turbaszek
Thank you for reviewing my PR. I am not sure if I understood well, so I may need your help.
The issue is in the bigquery hook, not the operators.
I have compared the method **insert_rows** for the two version you mentioned: v2.0.0 vs v1.28.0. The logic seems the same:
https://github.com/googleapis/python-bigquery/blob/v1.28.0/google/cloud/bigquery/client.py#L2780-#L2840
https://github.com/googleapis/python-bigquery/blob/v2.0.0/google/cloud/bigquery/client.py#L2776-#L2836
If you could point it out where the different logic is, it will help me. Otherwise I am not sure the version 2.0.0 will fix the issue.
The changes that I have proposed and introduced in my PR solves the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org