[GitHub] [flink] davidradl commented on a diff in pull request #23465: [FLINK-33147] Introduce endpoint field in REST API and deprecate host field

["davidradl (via GitHub)" <gi...@apache.org>]

davidradl commented on code in PR #23465:
URL: https://github.com/apache/flink/pull/23465#discussion_r1337150990


##########
docs/layouts/shortcodes/generated/rest_v1_dispatcher.html:
##########
@@ -2524,10 +2524,10 @@
         "type" : "object",
         "id" : "urn:jsonschema:org:apache:flink:runtime:rest:messages:JobExceptionsInfo:ExecutionExceptionInfo",
         "properties" : {
-          "exception" : {
+          "endpoint" : {
             "type" : "string"
           },
-          "location" : {

Review Comment:
   I see from the proposal that location will be changed to endpoint for consistency. I see there is a V1 dispatcher.
   I was expecting that the existing API would be unchanged so that existing users of the API will not be effected. I was expecting the new consistent API to all be in a higher version, so that users of the new API shape can use this version.   We could then deprecate the v1 API.
   I was looking for the tests to confirm that the original API performed the same and the new consistent API performed as expected. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org