You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "dqhl76 (via GitHub)" <gi...@apache.org> on 2023/10/28 09:52:26 UTC
[PR] [WIP]ci(services/azfile): add azfile integration test [incubator-opendal]
dqhl76 opened a new pull request, #3409:
URL: https://github.com/apache/incubator-opendal/pull/3409
close: #3047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(services/azfile): add azfile integration test [incubator-opendal]
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on code in PR #3409:
URL: https://github.com/apache/incubator-opendal/pull/3409#discussion_r1375247536
##########
.github/workflows/service_test_azfile.yml:
##########
@@ -0,0 +1,68 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Service Test Azfile
Review Comment:
migrated. Love the new workflow planner. So elegant!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(services/azfile): add azfile integration test [incubator-opendal]
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on code in PR #3409:
URL: https://github.com/apache/incubator-opendal/pull/3409#discussion_r1375371104
##########
bindings/java/Cargo.toml:
##########
@@ -82,6 +82,7 @@ services-all = [
"services-wasabi",
"services-mongodb",
"services-sqlite",
+ "services-azfile",
Review Comment:
It is under `services-all` not `default`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(services/azfile): add azfile integration test [incubator-opendal]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #3409:
URL: https://github.com/apache/incubator-opendal/pull/3409#issuecomment-1783809927
> Hi, @Xuanwo. I am not sure if it is a behavior we expected. I find a lot of empty random directory. It seems related to the random root path setting. Do we need to delete them?
> <img alt="image" width="1911" src="https://user-images.githubusercontent.com/69136320/278814438-bb89ff9b-15f1-45b8-8281-a40c4c61cc31.png">
What file path you find these files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(services/azfile): add azfile integration test [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3409:
URL: https://github.com/apache/incubator-opendal/pull/3409#discussion_r1375243295
##########
.github/workflows/service_test_azfile.yml:
##########
@@ -0,0 +1,68 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Service Test Azfile
Review Comment:
We are on the way to migrate our tests to the new workflow planner, please take a look over https://github.com/apache/incubator-opendal/pull/3391 as an example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(services/azfile): add azfile integration test [incubator-opendal]
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on PR #3409:
URL: https://github.com/apache/incubator-opendal/pull/3409#issuecomment-1784010313
Thanks for your review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(services/azfile): add azfile integration test [incubator-opendal]
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on PR #3409:
URL: https://github.com/apache/incubator-opendal/pull/3409#issuecomment-1783991660
> What file path you find these files?
Thanks for your reply. It is not related to random root setting. I have located the problem:
the empty directories are under the `root`. I found out that this was because some of our behavior tests not clean up the tested directory. For example, `test_list_dir_with_metakey_complete` just delete `path` but forget to delete `parent`. It is out of this PR's scope. I think this PR is ready to be reviewed.
https://github.com/apache/incubator-opendal/blob/3c4a18776892edb331acb3eddbd74fc926a93cd7/core/tests/behavior/list.rs#L141-L142
https://github.com/apache/incubator-opendal/blob/3c4a18776892edb331acb3eddbd74fc926a93cd7/core/tests/behavior/list.rs#L174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(services/azfile): add azfile integration test [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3409:
URL: https://github.com/apache/incubator-opendal/pull/3409#discussion_r1375375162
##########
bindings/java/Cargo.toml:
##########
@@ -82,6 +82,7 @@ services-all = [
"services-wasabi",
"services-mongodb",
"services-sqlite",
+ "services-azfile",
Review Comment:
Sorry for my mistakeš„µ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(services/azfile): add azfile integration test [incubator-opendal]
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on PR #3409:
URL: https://github.com/apache/incubator-opendal/pull/3409#issuecomment-1783801941
Hi, @Xuanwo. I am not sure if it is a behavior we expected. I find a lot of empty random directory. It seems related to the random root path setting. Should we need to delete them?
<img width="1911" alt="image" src="https://github.com/apache/incubator-opendal/assets/69136320/bb89ff9b-15f1-45b8-8281-a40c4c61cc31">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(services/azfile): add azfile integration test [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3409:
URL: https://github.com/apache/incubator-opendal/pull/3409#discussion_r1375366843
##########
bindings/java/Cargo.toml:
##########
@@ -82,6 +82,7 @@ services-all = [
"services-wasabi",
"services-mongodb",
"services-sqlite",
+ "services-azfile",
Review Comment:
Please don't add service in default list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci(services/azfile): add azfile integration test [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3409:
URL: https://github.com/apache/incubator-opendal/pull/3409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org