You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2023/04/27 00:55:14 UTC

[GitHub] [spark] cloud-fan commented on a diff in pull request #40890: [SPARK-43219][SQL][DOCS] Add `INSERT INTO REPLACE WHERE` statement into website

cloud-fan commented on code in PR #40890:
URL: https://github.com/apache/spark/pull/40890#discussion_r1178523834


##########
docs/sql-ref-syntax-dml-insert-table.md:
##########
@@ -26,8 +26,8 @@ The `INSERT` statement inserts new rows into a table or overwrites the existing
 ### Syntax
 
 ```sql
-INSERT [ INTO | OVERWRITE ] [ TABLE ] table_identifier [ partition_spec ] [ ( column_list ) ]
-    { VALUES ( { value | NULL } [ , ... ] ) [ , ( ... ) ] | query }
+INSERT [ INTO | OVERWRITE ] [ TABLE ] table_identifier [ [ partition_spec ] [ ( column_list ) ]
+    { VALUES ( { value | NULL } [ , ... ] ) [ , ( ... ) ] | query } | REPLACE WHERE boolean_expression query ]

Review Comment:
   This is not accurate. We should add a new SQL statement to document it
   ```
   INSERT [ INTO | OVERWRITE ] [ TABLE ] table_identifier ...
   
   INSERT INTO [ TABLE ] table_identifier REPLACE WHERE boolean_expression query ]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org