You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/05/09 18:05:46 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #4189: Simplify ObjectStore configuration pattern
tustvold opened a new pull request, #4189:
URL: https://github.com/apache/arrow-rs/pull/4189
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Relates to #4047
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Originally added in #3436 by @roeap, the API can be made simpler
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
This makes the config enumerations non exhaustive, so that options can be added without it being a breaking change
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #4189: Simplify ObjectStore configuration pattern
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4189:
URL: https://github.com/apache/arrow-rs/pull/4189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #4189: Simplify ObjectStore configuration pattern
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4189:
URL: https://github.com/apache/arrow-rs/pull/4189#issuecomment-1542262575
Thank you for the prompt review :muscle:
> Really looking forward to the deferred parsing as well
https://github.com/apache/arrow-rs/pull/4192 should be ready for review now, it currently only defers the parsing of values, and so the key arguments are still typed. I personally think this is more idiomatic, and allows users to choose how to handle unexpected keys, but appreciate opinions may differ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #4189: Simplify ObjectStore configuration pattern
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4189:
URL: https://github.com/apache/arrow-rs/pull/4189#issuecomment-1542233001
@roeap perhaps you might be able to give this a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4189: Simplify ObjectStore configuration pattern
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4189:
URL: https://github.com/apache/arrow-rs/pull/4189#discussion_r1189751976
##########
object_store/src/aws/mod.rs:
##########
@@ -742,18 +727,28 @@ impl AmazonS3Builder {
AmazonS3ConfigKey::UnsignedPayload => {
self.unsigned_payload = str_is_truthy(&value.into())
}
- AmazonS3ConfigKey::Checksum => {
- let algorithm = Checksum::try_from(&value.into())
- .map_err(|_| Error::InvalidChecksumAlgorithm)?;
Review Comment:
This is fixed properly in https://github.com/apache/arrow-rs/pull/4192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4189: Simplify ObjectStore configuration pattern
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4189:
URL: https://github.com/apache/arrow-rs/pull/4189#discussion_r1188962166
##########
object_store/src/aws/mod.rs:
##########
@@ -742,18 +727,28 @@ impl AmazonS3Builder {
AmazonS3ConfigKey::UnsignedPayload => {
self.unsigned_payload = str_is_truthy(&value.into())
}
- AmazonS3ConfigKey::Checksum => {
- let algorithm = Checksum::try_from(&value.into())
- .map_err(|_| Error::InvalidChecksumAlgorithm)?;
Review Comment:
This was problematic as this error would get unwrapped in from_env
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org