You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2019/05/09 16:45:48 UTC
[GitHub] [bookkeeper] karanmehta93 commented on a change in pull request
#2090: Update and flush lastLogMark when replaying journal
karanmehta93 commented on a change in pull request #2090: Update and flush lastLogMark when replaying journal
URL: https://github.com/apache/bookkeeper/pull/2090#discussion_r282571183
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
##########
@@ -196,11 +196,11 @@ void rollLog(LastLogMark lastMark) throws NoWritableLedgerDirException {
// which is safe since records before lastMark have been
// persisted to disk (both index & entry logger)
lastMark.getCurMark().writeLogMark(bb);
- if (LOG.isDebugEnabled()) {
- LOG.debug("RollLog to persist last marked log : {}", lastMark.getCurMark());
- }
+
+ LOG.info("RollLog to persist last marked log : {}", lastMark.getCurMark());
+
List<File> writableLedgerDirs = ledgerDirsManager
- .getWritableLedgerDirs();
+ .getWritableLedgerDirsForNewLog();
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services