[GitHub] [spark] gengliangwang commented on a change in pull request #29564: [WIP][SPARK-32708] Query optimization fails to reuse exchange with DataSourceV2

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #29564:
URL: https://github.com/apache/spark/pull/29564#discussion_r486905881



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala
##########
@@ -393,6 +393,29 @@ class DataSourceV2Suite extends QueryTest with SharedSQLContext {
       }
     }
   }
+
+  test("SPARK-32708: same columns with different ExprIds should be equal after canonicalization ") {

Review comment:
       @cloud-fan I think this test case creates two `DataSourceV2ScanExec` and do the check. It looks ok to me.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org