You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2024/01/16 17:56:08 UTC
[I] Feature request:Add missing java api for `StreamTestKit` [incubator-pekko]
He-Pin opened a new issue, #970:
URL: https://github.com/apache/incubator-pekko/issues/970
Motivation:
Currently there are some methods are missing in the StreamTestkit for javadsl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Feature request:Add missing java api for `StreamTestKit` [incubator-pekko]
Posted by "naosense (via GitHub)" <gi...@apache.org>.
naosense commented on issue #970:
URL: https://github.com/apache/incubator-pekko/issues/970#issuecomment-1911627461
As it was said in the WeChat group, should I change FiniteDuration to java.time.Duration, or add some equalent methods with java.time.Duration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Feature request:Add missing java api for `StreamTestKit` [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #970:
URL: https://github.com/apache/incubator-pekko/issues/970#issuecomment-1911688892
@naosense You can take a look at https://github.com/apache/incubator-pekko/blob/main/CONTRIBUTING.md#java-apis-in-pekko for the type mapping, hope you have a nice ride, and thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Feature request:Add missing java api for `StreamTestKit` [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #970:
URL: https://github.com/apache/incubator-pekko/issues/970#issuecomment-1911654937
I was on meeting, you should keep the method the same, but adopt the Scala type to Java native type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Feature request:Add missing java api for `StreamTestKit` [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin closed issue #970: Feature request:Add missing java api for `StreamTestKit`
URL: https://github.com/apache/pekko/issues/970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Feature request:Add missing java api for `StreamTestKit` [incubator-pekko]
Posted by "naosense (via GitHub)" <gi...@apache.org>.
naosense commented on issue #970:
URL: https://github.com/apache/incubator-pekko/issues/970#issuecomment-1898142233
I checked the java version of `StreamTestKit` and it is quite different from the scala version. As much as I want to help, but I don't know how to get started, can you give me more detailed instructions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Feature request:Add missing java api for `StreamTestKit` [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #970:
URL: https://github.com/apache/incubator-pekko/issues/970#issuecomment-1911640248
> As it was said in the WeChat group, should I change FiniteDuration to java.time.Duration, or add some equalent methods with java.time.Duration?
@naosense Yes you should, other parts of the `javaapi` for pekko-streams use `java.time.Duration`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Feature request:Add missing java api for `StreamTestKit` [incubator-pekko]
Posted by "naosense (via GitHub)" <gi...@apache.org>.
naosense commented on issue #970:
URL: https://github.com/apache/incubator-pekko/issues/970#issuecomment-1911726455
I created a PR, but I don't have permission to add a reviewer, please take a look when you have time @He-Pin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Feature request:Add missing java api for `StreamTestKit` [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #970:
URL: https://github.com/apache/incubator-pekko/issues/970#issuecomment-1898181269
@naosense Thanks for intreast this.
This one, you will see there are many scala methods don't have related java api.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] Feature request:Add missing java api for `StreamTestKit` [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #970:
URL: https://github.com/apache/incubator-pekko/issues/970#issuecomment-1911727760
> I created a PR, but I don't have permission to add a reviewer, please take a look when you have time @He-Pin
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org