[GitHub] [airflow] akki commented on a change in pull request #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator)

[GitBox <gi...@apache.org>]

akki commented on a change in pull request #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator)
URL: https://github.com/apache/airflow/pull/5489#discussion_r299301075
 
 

 ##########
 File path: airflow/contrib/operators/swarm_operator.py
 ##########
 @@ -0,0 +1,146 @@
+'''
+Run ephemeral Docker Swarm services
+'''
+# -*- coding: utf-8 -*-
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from docker import types
+
+from airflow.exceptions import AirflowException
+from airflow.operators.docker_operator import DockerOperator
+from airflow.utils.decorators import apply_defaults
+from airflow.utils.strings import get_random_string
+
+
+class SwarmOperator(DockerOperator):
 
 Review comment:
   I agree `Swarm` is not as popular as `Docker`, so prepending `Docker` makes sense to me.
   
   This Operator works in the same fashion as the existing `DockerOperator` in Airflow - since that doesn't have `ExecuteCommand` in its name, I don't see the need to add it here either. (Or am I missing your point?)
   
   So WDYT about `DockerSwarmOperator`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services