You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "nicolas de loof (JIRA)" <ji...@codehaus.org> on 2006/01/31 17:41:06 UTC
[jira] Created: (MAVEN-1741) maven 1.1 fails to run
commons-attributes in mutliproject mode on a war project
maven 1.1 fails to run commons-attributes in mutliproject mode on a war project
-------------------------------------------------------------------------------
Key: MAVEN-1741
URL: http://jira.codehaus.org/browse/MAVEN-1741
Project: Maven
Type: Bug
Versions: 1.1-beta-2
Reporter: nicolas de loof
Priority: Minor
Attachments: test_maven11_commons-attributes.zip
Attached zip contains a minimalist multiproject using commons-attributes that demonstrates the bug.
- head (top level project)
- jar (minimalist jar project) : Sample.java has a "java.util.Date" attribute
- war (minimalist war project) : Sample.java has a "java.util.Date" attribute
When runing "maven war:install" on war project, attributes are generated as expected.
When running from "head" project using "maven multiproject:install", commons-attributes are
- generated as expected for the jar
- NOT generated in the war (no log from plugin)
I don't know if this is a maven, multiproject-plugin, war-plugin or commons-attributes-plugin bug.
Please notice commons-attributes plugin uses a preGoal to automatically register itself.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MAVEN-1741) maven 1.1 fails to run
commons-attributes in mutliproject mode on a war project
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MAVEN-1741?page=comments#action_60337 ]
Lukas Theussl commented on MAVEN-1741:
--------------------------------------
There was actually an issue open for that: MPHTMLXDOC-6, which I closed as won't fix, but I am not so sure on that anymore.
I'll leave this one open for the moment as I think there is a legitimate bug somewhere buried here: prereqs seem to be called once only as long as you don't call attainGoal somewhere in between - I'll try to construct a simple test case.
Just for reference: see also my struggles at MPXDOC-181.
> maven 1.1 fails to run commons-attributes in mutliproject mode on a war project
> -------------------------------------------------------------------------------
>
> Key: MAVEN-1741
> URL: http://jira.codehaus.org/browse/MAVEN-1741
> Project: Maven
> Type: Bug
> Versions: 1.1-beta-2
> Reporter: nicolas de loof
> Priority: Minor
> Attachments: test_maven11_commons-attributes.zip
>
>
> Attached zip contains a minimalist multiproject using commons-attributes that demonstrates the bug.
> - head (top level project)
> - jar (minimalist jar project) : Sample.java has a "java.util.Date" attribute
> - war (minimalist war project) : Sample.java has a "java.util.Date" attribute
> When runing "maven war:install" on war project, attributes are generated as expected.
> When running from "head" project using "maven multiproject:install", commons-attributes are
> - generated as expected for the jar
> - NOT generated in the war (no log from plugin)
> I don't know if this is a maven, multiproject-plugin, war-plugin or commons-attributes-plugin bug.
> Please notice commons-attributes plugin uses a preGoal to automatically register itself.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MAVEN-1741) maven 1.1 fails to run
commons-attributes in mutliproject mode on a war project
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MAVEN-1741?page=comments#action_59133 ]
Lukas Theussl commented on MAVEN-1741:
--------------------------------------
I think (I am not sure, I have to check the archives) that this is actually the intented behavior in maven 1.1. A pregoal is always only executed once in a build cycle, as you usually don't want the same pregoal executed several times from different goals to avoid overhead. If you want to make sure that a goal gets executed, you have to use the <attainGoal> tag. At least that's the behavior that I would expect.
> maven 1.1 fails to run commons-attributes in mutliproject mode on a war project
> -------------------------------------------------------------------------------
>
> Key: MAVEN-1741
> URL: http://jira.codehaus.org/browse/MAVEN-1741
> Project: Maven
> Type: Bug
> Versions: 1.1-beta-2
> Reporter: nicolas de loof
> Priority: Minor
> Attachments: test_maven11_commons-attributes.zip
>
>
> Attached zip contains a minimalist multiproject using commons-attributes that demonstrates the bug.
> - head (top level project)
> - jar (minimalist jar project) : Sample.java has a "java.util.Date" attribute
> - war (minimalist war project) : Sample.java has a "java.util.Date" attribute
> When runing "maven war:install" on war project, attributes are generated as expected.
> When running from "head" project using "maven multiproject:install", commons-attributes are
> - generated as expected for the jar
> - NOT generated in the war (no log from plugin)
> I don't know if this is a maven, multiproject-plugin, war-plugin or commons-attributes-plugin bug.
> Please notice commons-attributes plugin uses a preGoal to automatically register itself.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MAVEN-1741) maven 1.1 fails to run
commons-attributes in mutliproject mode on a war project
Posted by "nicolas de loof (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MAVEN-1741?page=comments#action_59103 ]
nicolas de loof commented on MAVEN-1741:
----------------------------------------
I've made some other tests: I've converter the war project in the attached zip to a simple jar.
commons-attributes plugin is executed ONLY on the FIRST project that uses it in the multiproject build.
-> this bug is not related to war plugin.
I've patched my commons-attribute plugin Jelly script to echo on <preGoal name="java:compile"> , before anything from plugin is executed.
The pregoal is NOT executed after first subproject is build by multiproject.
-> this bug is not related to commons-attributes plugin
Now, there is AFAIK only one possible source for this bug :
The reactor does not handle preGoals registration from plugins as expected (as it does on maven 1.0.x)
I don't know about maven Internals and cannot go deeper on this issue.
> maven 1.1 fails to run commons-attributes in mutliproject mode on a war project
> -------------------------------------------------------------------------------
>
> Key: MAVEN-1741
> URL: http://jira.codehaus.org/browse/MAVEN-1741
> Project: Maven
> Type: Bug
> Versions: 1.1-beta-2
> Reporter: nicolas de loof
> Priority: Minor
> Attachments: test_maven11_commons-attributes.zip
>
>
> Attached zip contains a minimalist multiproject using commons-attributes that demonstrates the bug.
> - head (top level project)
> - jar (minimalist jar project) : Sample.java has a "java.util.Date" attribute
> - war (minimalist war project) : Sample.java has a "java.util.Date" attribute
> When runing "maven war:install" on war project, attributes are generated as expected.
> When running from "head" project using "maven multiproject:install", commons-attributes are
> - generated as expected for the jar
> - NOT generated in the war (no log from plugin)
> I don't know if this is a maven, multiproject-plugin, war-plugin or commons-attributes-plugin bug.
> Please notice commons-attributes plugin uses a preGoal to automatically register itself.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MAVEN-1741) maven 1.1 fails to run
commons-attributes in mutliproject mode on a war project
Posted by "nicolas de loof (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MAVEN-1741?page=comments#action_60213 ]
nicolas de loof commented on MAVEN-1741:
----------------------------------------
I can agree with this 1.1 new requirement for only-1-run preGoals.
This may then require some upgrade to commons-attributes and html2xdoc plugins :
html2xodc uses a xdoc:init preGoal to run if maven.html2xdoc.enabled=true
(I don't know other official plugins that use pre/post Goals)
So this bug can be moved from MAVEN to MPHTMLXDOC
> maven 1.1 fails to run commons-attributes in mutliproject mode on a war project
> -------------------------------------------------------------------------------
>
> Key: MAVEN-1741
> URL: http://jira.codehaus.org/browse/MAVEN-1741
> Project: Maven
> Type: Bug
> Versions: 1.1-beta-2
> Reporter: nicolas de loof
> Priority: Minor
> Attachments: test_maven11_commons-attributes.zip
>
>
> Attached zip contains a minimalist multiproject using commons-attributes that demonstrates the bug.
> - head (top level project)
> - jar (minimalist jar project) : Sample.java has a "java.util.Date" attribute
> - war (minimalist war project) : Sample.java has a "java.util.Date" attribute
> When runing "maven war:install" on war project, attributes are generated as expected.
> When running from "head" project using "maven multiproject:install", commons-attributes are
> - generated as expected for the jar
> - NOT generated in the war (no log from plugin)
> I don't know if this is a maven, multiproject-plugin, war-plugin or commons-attributes-plugin bug.
> Please notice commons-attributes plugin uses a preGoal to automatically register itself.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org