[GitHub] [incubator-superset] rusackas commented on issue #8553: [dashboard scoped filter] Improve scroll inside modal

[GitBox <gi...@apache.org>]

rusackas commented on issue #8553: [dashboard scoped filter] Improve scroll inside modal
URL: https://github.com/apache/incubator-superset/pull/8553#issuecomment-553546586
 
 
   @graceguo-supercat This looks like a good improvement to me!  I'm wondering about a couple enhancements, which I can look at in a follow-up PR if you'd like:
   
   • Would it be even better if just the individual tree were to scroll? In this case, that would be just the right side's tree. Optionally, it could even leave the Expand/Collapse/Search pinned to the top. 
   
   • I see the Less file has some significant-looking static values (128px, 64px, ...). I didn't look super closely at these, but if they're making space for other elements (i.e. a header), would it add value to use Less variables, so that we can tweak more easily in the future? I've been meaning to make a pass at the Less files in general looking for this sort of thing, hoping we can use more Less variables for "style guide" kind of things.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org