[GitHub] markusthoemmes commented on a change in pull request #3671: Activation id in header

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #3671: Activation id in header
URL: https://github.com/apache/incubator-openwhisk/pull/3671#discussion_r204346654
 
 

 ##########
 File path: tests/src/test/scala/whisk/core/controller/test/ActionsApiTests.scala
 ##########
 @@ -1043,13 +1043,15 @@ class ActionsApiTests extends ControllerTestCommon with WhiskActionsApi {
       status should be(Accepted)
       val response = responseAs[JsObject]
       response.fields("activationId") should not be None
+      headers.exists(_.is(ActivationIdHeaderInLowercase)) should be(true)
 
 Review comment:
   headers are immutable and per the line above you know the correct activation id. You should be able to rewrite this to something like:
   
   ```scala
   headers should contain(RawHeader(ActivationIdHeader, response.fields("activationId").convertTo[String]))
   ```
   
   That'll give you a more explanatory response in tests. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services