[GitHub] [apisix] spacewander commented on a change in pull request #2856: fix: validate plugin configuration in the DP

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #2856:
URL: https://github.com/apache/apisix/pull/2856#discussion_r531563032



##########
File path: apisix/core/config_etcd.lua
##########
@@ -256,6 +264,14 @@ local function sync_data(self)
                     end
                 end
 
+                if data_valid and self.checker then
+                    data_valid, err = self.checker(item.value)
+                    if not data_valid then
+                        log.error("failed to check item data of [", self.key,
+                                "] err:", err, " ,val: ", json.delay_encode(item.value))

Review comment:
       Updated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org