You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/03 03:04:35 UTC
[GitHub] [superset] betodealmeida opened a new pull request #14960: fix: font regression in SQL Lab
betodealmeida opened a new pull request #14960:
URL: https://github.com/apache/superset/pull/14960
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
In SQL Lab we wrap the error message in a `<MonospaceDiv>` to show the error messages with a monospaced font. But this is being dropped if there's a custom error component registered for the error.
I fixed it by passing the monospaced error (`subtitle`) to the custom error component.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before:
After:
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida merged pull request #14960: fix: font regression in SQL Lab
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #14960:
URL: https://github.com/apache/superset/pull/14960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #14960: fix: font regression in SQL Lab
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #14960:
URL: https://github.com/apache/superset/pull/14960#issuecomment-854054623
I manually tested and it looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #14960: fix: font regression in SQL Lab
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #14960:
URL: https://github.com/apache/superset/pull/14960#issuecomment-854043697
@betodealmeida I think there's also some styling issues when reloading the page. Do you want to add that in this PR too or keep it separate?
<img width="1370" alt="_DEV__Superset" src="https://user-images.githubusercontent.com/5186919/120685931-47c09600-c455-11eb-81d4-dc51e041eebb.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho removed a comment on pull request #14960: fix: font regression in SQL Lab
Posted by GitBox <gi...@apache.org>.
eschutho removed a comment on pull request #14960:
URL: https://github.com/apache/superset/pull/14960#issuecomment-854043697
@betodealmeida I think there's also some styling issues when reloading the page. Do you want to add that in this PR too or keep it separate?
<img width="1370" alt="_DEV__Superset" src="https://user-images.githubusercontent.com/5186919/120685931-47c09600-c455-11eb-81d4-dc51e041eebb.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #14960: fix: font regression in SQL Lab
Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #14960:
URL: https://github.com/apache/superset/pull/14960#issuecomment-854043697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho removed a comment on pull request #14960: fix: font regression in SQL Lab
Posted by GitBox <gi...@apache.org>.
eschutho removed a comment on pull request #14960:
URL: https://github.com/apache/superset/pull/14960#issuecomment-854043697
@betodealmeida I think there's also some styling issues when reloading the page. Do you want to add that in this PR too or keep it separate?
<img width="1370" alt="_DEV__Superset" src="https://user-images.githubusercontent.com/5186919/120685931-47c09600-c455-11eb-81d4-dc51e041eebb.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org