You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/03 10:40:54 UTC
[GitHub] [incubator-dolphinscheduler] elonlo opened a new pull request
#1700: Fixed tasks_queue and tasks_kill did not exist in zookeeper #1696
elonlo opened a new pull request #1700: Fixed tasks_queue and tasks_kill did not exist in zookeeper #1696
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1700
## What is the purpose of the pull request
*Fixed the issue that tasks_queue and tasks_kill did not exist in zookeeper*
## Brief change log
- *Add create tasks node logic to TaskQueueZkImpl.java*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in
pull request #1700: Fixed tasks_queue and tasks_kill did not exist in
zookeeper #1696
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #1700: Fixed tasks_queue and tasks_kill did not exist in zookeeper #1696
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1700#discussion_r362776722
##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/queue/TaskQueueZkImpl.java
##########
@@ -37,8 +37,27 @@
private static final Logger logger = LoggerFactory.getLogger(TaskQueueZkImpl.class);
+ private final ZookeeperOperator zookeeperOperator;
+
@Autowired
- private ZookeeperOperator zookeeperOperator;
+ public TaskQueueZkImpl(ZookeeperOperator zookeeperOperator) {
+ this.zookeeperOperator = zookeeperOperator;
+
+ try {
+ String tasksQueuePath = getTasksPath(Constants.DOLPHINSCHEDULER_TASKS_QUEUE);
+ String tasksCancelPath = getTasksPath(Constants.DOLPHINSCHEDULER_TASKS_KILL);
Review comment:
tasksCancelPath --> tasksKillPath
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1700:
Fixed tasks_queue and tasks_kill did not exist in zookeeper #1696
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1700: Fixed tasks_queue and tasks_kill did not exist in zookeeper #1696
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1700#issuecomment-570538501
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700?src=pr&el=h1) Report
> Merging [#1700](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/3477d28de872c7a7a7d05146665a1dc9f095cb64?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1700 +/- ##
==========================================
- Coverage 17.18% 17.16% -0.02%
==========================================
Files 285 285
Lines 13882 13894 +12
Branches 2264 2266 +2
==========================================
Hits 2385 2385
- Misses 11222 11234 +12
Partials 275 275
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dolphinscheduler/common/queue/TaskQueueZkImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3F1ZXVlL1Rhc2tRdWV1ZVprSW1wbC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700?src=pr&el=footer). Last update [3477d28...c21d25e](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- merged pull request #1700:
Fixed tasks_queue and tasks_kill did not exist in zookeeper #1696
Posted by GitBox <gi...@apache.org>.
Technoboy- merged pull request #1700: Fixed tasks_queue and tasks_kill did not exist in zookeeper #1696
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1700: Fixed tasks_queue and tasks_kill did not exist in zookeeper #1696
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1700: Fixed tasks_queue and tasks_kill did not exist in zookeeper #1696
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1700#issuecomment-570538501
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700?src=pr&el=h1) Report
> Merging [#1700](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/3477d28de872c7a7a7d05146665a1dc9f095cb64?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1700 +/- ##
==========================================
- Coverage 17.18% 17.15% -0.03%
==========================================
Files 285 285
Lines 13882 13900 +18
Branches 2264 2267 +3
==========================================
Hits 2385 2385
- Misses 11222 11240 +18
Partials 275 275
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dolphinscheduler/common/queue/TaskQueueZkImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3F1ZXVlL1Rhc2tRdWV1ZVprSW1wbC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...pache/dolphinscheduler/common/utils/EnumUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0VudW1VdGlscy5qYXZh) | `27.27% <0%> (-32.73%)` | :arrow_down: |
| [...heduler/server/master/runner/MasterExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyRXhlY1RocmVhZC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...lphinscheduler/server/worker/task/sql/SqlTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL3NxbC9TcWxUYXNrLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...cheduler/server/worker/runner/FetchTaskThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9ydW5uZXIvRmV0Y2hUYXNrVGhyZWFkLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700?src=pr&el=footer). Last update [3477d28...cae656c](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1700?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services