You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by bu...@apache.org on 2007/05/18 12:39:37 UTC
DO NOT REPLY [Bug 42450] New: - [PATCH] avoid code duplication in 2xhtml transformation pipeline
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42450>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42450
Summary: [PATCH] avoid code duplication in <doctype>2xhtml
transformation pipeline
Product: Lenya
Version: 1.4
Platform: Other
OS/Version: other
Status: NEW
Severity: enhancement
Priority: P2
Component: Default Publication
AssignedTo: dev@lenya.apache.org
ReportedBy: nettings@apache.org
currently, we have a selector that checks for the existence of a
doctype-specific xslt, and if it does not exist, falls back to the standard
xhtml one. since that transformation takes a huge number of parameters, this
leads to a big chunk of duplicated code.
the attached patch refactors the selector into a separate pipeline that
generates the stylesheet, so that the parameters do not have to be listed twice.
i'd like to sneak this in before 1.4.0 for aesthetic reasons, but i'd like to
hear some opinions before i do that...
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42450] - [PATCH] avoid code duplication in 2xhtml transformation pipeline
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42450>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42450
------- Additional Comments From nettings@apache.org 2007-05-18 03:52 -------
Created an attachment (id=20214)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20214&action=view)
simplify publication sitemap
move doctype transformer xsl selection into a separate pipeline.
one functional change: currently, we are falling back to page2xhtml-xhtml.xsl
if no doctype-specific stylesheet exists.
i think this should be page2xhtml.xsl instead (doctype-independent default).
the patch changes this accordingly.
please review!
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42450] - [PATCH] avoid code duplication in 2xhtml transformation pipeline
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42450>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42450
------- Additional Comments From bobharner@gmail.com 2007-05-18 09:54 -------
This looks like a nice clean, low-risk improvement to me. And I'm so glad to
see you commented your code!
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42450] - [PATCH] avoid code duplication in 2xhtml transformation pipeline
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42450>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42450
------- Additional Comments From thorsten@apache.org 2007-05-18 15:44 -------
+1
Please apply it.
TIA
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42450] - [PATCH] avoid code duplication in 2xhtml transformation pipeline
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42450>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42450
thorsten@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|1.4 |2.0
Version|1.4 |2.0
------- Additional Comments From thorsten@apache.org 2007-07-16 01:59 -------
Renaming Lenya 1.4 to 2.0
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42450] - [PATCH] avoid code duplication in 2xhtml transformation pipeline
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42450>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42450
nettings@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From nettings@apache.org 2007-05-19 01:10 -------
thanks for your comments. committed.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org