You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sammy Yu (JIRA)" <ji...@apache.org> on 2009/07/01 19:11:47 UTC

[jira] Created: (CASSANDRA-272) Enhance how metrics are exposed

Enhance how metrics are exposed
-------------------------------

                 Key: CASSANDRA-272
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-272
             Project: Cassandra
          Issue Type: New Feature
    Affects Versions: 0.3
            Reporter: Sammy Yu
            Assignee: Sammy Yu
            Priority: Minor
             Fix For: 0.3


Had discussion on IRC about the metric interfaces that are used in the code today.  There are two sets one using IAnalyticsSource to send data to Gangalia and another set of interface using JMX MBeans (ie, ColumnStoreFamily).  

Since FB is not using Gangalia anymore and it looks like the other VMAnalyticsSource is already available via JMX, we should prefer to expose metrics through JMX.  I will add a new TableMBean which exposes the metrics in  DBAnalyticsSource.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-272) Enhance how metrics are exposed

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727825#action_12727825 ] 

Eric Evans commented on CASSANDRA-272:
--------------------------------------

After some discussion on IRC between myself, Sammy, and Jonathan, it was decided that a) we'll go without a TableMBean unless/until there something Table-specific to expose, and b) we need a CFSMbean organization that is human readable as well, possibly by manipulating the object name to parent by tablename instead of CF name.

> Enhance how metrics are exposed
> -------------------------------
>
>                 Key: CASSANDRA-272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-272
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: 0.3
>            Reporter: Sammy Yu
>            Assignee: Sammy Yu
>            Priority: Minor
>             Fix For: 0.3
>
>         Attachments: 0001--Work-for-cassandra-272.patch, 0002--Work-for-cassandra-272.patch
>
>
> Had discussion on IRC about the metric interfaces that are used in the code today.  There are two sets one using IAnalyticsSource to send data to Gangalia and another set of interface using JMX MBeans (ie, ColumnStoreFamily).  
> Since FB is not using Gangalia anymore and it looks like the other VMAnalyticsSource is already available via JMX, we should prefer to expose metrics through JMX.  I will add a new TableMBean which exposes the metrics in  DBAnalyticsSource.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-272) Enhance how metrics are exposed

Posted by "Sammy Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sammy Yu updated CASSANDRA-272:
-------------------------------

    Attachment: 0001--Work-for-cassandra-272.patch

> Enhance how metrics are exposed
> -------------------------------
>
>                 Key: CASSANDRA-272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-272
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: 0.3
>            Reporter: Sammy Yu
>            Assignee: Sammy Yu
>            Priority: Minor
>             Fix For: 0.3
>
>         Attachments: 0001--Work-for-cassandra-272.patch
>
>
> Had discussion on IRC about the metric interfaces that are used in the code today.  There are two sets one using IAnalyticsSource to send data to Gangalia and another set of interface using JMX MBeans (ie, ColumnStoreFamily).  
> Since FB is not using Gangalia anymore and it looks like the other VMAnalyticsSource is already available via JMX, we should prefer to expose metrics through JMX.  I will add a new TableMBean which exposes the metrics in  DBAnalyticsSource.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-272) Enhance how metrics are exposed

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729233#action_12729233 ] 

Hudson commented on CASSANDRA-272:
----------------------------------

Integrated in Cassandra #132 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/132/])
    expose CF write count/latency via JMX

Patch by Sammy Yu; reviewed by Eric Evans for 


> Enhance how metrics are exposed
> -------------------------------
>
>                 Key: CASSANDRA-272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-272
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: 0.3
>            Reporter: Sammy Yu
>            Assignee: Sammy Yu
>            Priority: Minor
>             Fix For: 0.3
>
>         Attachments: 0001--Work-for-cassandra-272.patch, 0002--Work-for-cassandra-272.patch, 0003-Work-for-CASSANDRA-272.patch, 0004-Work-for-CASSANDRA-272.patch
>
>
> Had discussion on IRC about the metric interfaces that are used in the code today.  There are two sets one using IAnalyticsSource to send data to Gangalia and another set of interface using JMX MBeans (ie, ColumnStoreFamily).  
> Since FB is not using Gangalia anymore and it looks like the other VMAnalyticsSource is already available via JMX, we should prefer to expose metrics through JMX.  I will add a new TableMBean which exposes the metrics in  DBAnalyticsSource.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CASSANDRA-272) Enhance how metrics are exposed

Posted by "Sammy Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727398#action_12727398 ] 

Sammy Yu edited comment on CASSANDRA-272 at 7/5/09 11:00 PM:
-------------------------------------------------------------

0002 is self-contained patch (ignore 0001 patch):
   * Registers the mbean properly to use domain, type, and key-value pairs
   * Adds write latency and operation metric to super column family mbean
   * All table metric calculation is calculated at the super column level
   * Adds a new nodeprobe stat command which retrieves these metrics



      was (Author: sammy.yu):
    Self-contained patch, ignore previous 0001 patch.
  
> Enhance how metrics are exposed
> -------------------------------
>
>                 Key: CASSANDRA-272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-272
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: 0.3
>            Reporter: Sammy Yu
>            Assignee: Sammy Yu
>            Priority: Minor
>             Fix For: 0.3
>
>         Attachments: 0001--Work-for-cassandra-272.patch, 0002--Work-for-cassandra-272.patch
>
>
> Had discussion on IRC about the metric interfaces that are used in the code today.  There are two sets one using IAnalyticsSource to send data to Gangalia and another set of interface using JMX MBeans (ie, ColumnStoreFamily).  
> Since FB is not using Gangalia anymore and it looks like the other VMAnalyticsSource is already available via JMX, we should prefer to expose metrics through JMX.  I will add a new TableMBean which exposes the metrics in  DBAnalyticsSource.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-272) Enhance how metrics are exposed

Posted by "Sammy Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sammy Yu updated CASSANDRA-272:
-------------------------------

    Attachment: 0003-Work-for-CASSANDRA-272.patch

 * Removed TableMBean
 * Register CFMBean so that the name is the tablename and supercolumn key is the name of supercolumn.
 * Modified nodeprobe to calculate the table metrics



> Enhance how metrics are exposed
> -------------------------------
>
>                 Key: CASSANDRA-272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-272
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: 0.3
>            Reporter: Sammy Yu
>            Assignee: Sammy Yu
>            Priority: Minor
>             Fix For: 0.3
>
>         Attachments: 0001--Work-for-cassandra-272.patch, 0002--Work-for-cassandra-272.patch, 0003-Work-for-CASSANDRA-272.patch
>
>
> Had discussion on IRC about the metric interfaces that are used in the code today.  There are two sets one using IAnalyticsSource to send data to Gangalia and another set of interface using JMX MBeans (ie, ColumnStoreFamily).  
> Since FB is not using Gangalia anymore and it looks like the other VMAnalyticsSource is already available via JMX, we should prefer to expose metrics through JMX.  I will add a new TableMBean which exposes the metrics in  DBAnalyticsSource.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-272) Enhance how metrics are exposed

Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Greene updated CASSANDRA-272:
-------------------------------------

    Component/s: Tools

> Enhance how metrics are exposed
> -------------------------------
>
>                 Key: CASSANDRA-272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-272
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>    Affects Versions: 0.3
>            Reporter: Sammy Yu
>            Assignee: Sammy Yu
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: 0001--Work-for-cassandra-272.patch, 0002--Work-for-cassandra-272.patch, 0003-Work-for-CASSANDRA-272.patch, 0004-Work-for-CASSANDRA-272.patch
>
>
> Had discussion on IRC about the metric interfaces that are used in the code today.  There are two sets one using IAnalyticsSource to send data to Gangalia and another set of interface using JMX MBeans (ie, ColumnStoreFamily).  
> Since FB is not using Gangalia anymore and it looks like the other VMAnalyticsSource is already available via JMX, we should prefer to expose metrics through JMX.  I will add a new TableMBean which exposes the metrics in  DBAnalyticsSource.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-272) Enhance how metrics are exposed

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728721#action_12728721 ] 

Eric Evans commented on CASSANDRA-272:
--------------------------------------

committed, thanks!

> Enhance how metrics are exposed
> -------------------------------
>
>                 Key: CASSANDRA-272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-272
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: 0.3
>            Reporter: Sammy Yu
>            Assignee: Sammy Yu
>            Priority: Minor
>             Fix For: 0.3
>
>         Attachments: 0001--Work-for-cassandra-272.patch, 0002--Work-for-cassandra-272.patch, 0003-Work-for-CASSANDRA-272.patch, 0004-Work-for-CASSANDRA-272.patch
>
>
> Had discussion on IRC about the metric interfaces that are used in the code today.  There are two sets one using IAnalyticsSource to send data to Gangalia and another set of interface using JMX MBeans (ie, ColumnStoreFamily).  
> Since FB is not using Gangalia anymore and it looks like the other VMAnalyticsSource is already available via JMX, we should prefer to expose metrics through JMX.  I will add a new TableMBean which exposes the metrics in  DBAnalyticsSource.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-272) Enhance how metrics are exposed

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728178#action_12728178 ] 

Eric Evans commented on CASSANDRA-272:
--------------------------------------

First off, using objects named for the table instead of the column produces a very readable layout in jconsole. That's a keeper. :)

A few things though:

The methods that were added to Table for the MBean are still there, can I get you to resubmit the patch without those?

Since ColumnFamilyStore.getTableName() isn't actually used anywhere, it's probably safe to assume that it isn't needed, can you remove that as well?

And on an OCD related front.... :)

NodeProbe is basically the place to query node-specific info, so it's probably wise to avoid overly generic identifiers like "stats" that might conflict with other statistics oriented instrumentation in the future. I think we should rename the getStats() method to something like getColumnFamilyStats() instead. I'm sure the same applies to the "stats" command argument, though I don't feel as strongly about that one. If you wanted to rename it as well, maybe "dbstats" or "cfstats"?

On a code style/consistency/readability front. NodeProbe.getStats() has some unusually long lines, mostly caused by very long variable names like "tableNameToColumnFamilyStoreMBean". These verbose/descriptive names are good when used at the class/instance level or when appearing in a method signature, but are less useful when the scope is local.

> Enhance how metrics are exposed
> -------------------------------
>
>                 Key: CASSANDRA-272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-272
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: 0.3
>            Reporter: Sammy Yu
>            Assignee: Sammy Yu
>            Priority: Minor
>             Fix For: 0.3
>
>         Attachments: 0001--Work-for-cassandra-272.patch, 0002--Work-for-cassandra-272.patch, 0003-Work-for-CASSANDRA-272.patch
>
>
> Had discussion on IRC about the metric interfaces that are used in the code today.  There are two sets one using IAnalyticsSource to send data to Gangalia and another set of interface using JMX MBeans (ie, ColumnStoreFamily).  
> Since FB is not using Gangalia anymore and it looks like the other VMAnalyticsSource is already available via JMX, we should prefer to expose metrics through JMX.  I will add a new TableMBean which exposes the metrics in  DBAnalyticsSource.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-272) Enhance how metrics are exposed

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726158#action_12726158 ] 

Jonathan Ellis commented on CASSANDRA-272:
------------------------------------------

Yes, please have a look at DBAS, expose the relevant ones via JMX, and get rid of the old ganglia stuff.

If we are tracking the same stat in two places though for table/CF we should just track it in CF and then report the table stat by aggregating the CF ones.  (Even for a few thousand CFs, far more than anyone actually uses at this point, this is a reasonable approach.)

I also had a note over in CASSANDRA-183 (which I will close in favor of this one): "DBAS updating in Table is very repetitive, shouldn't that be done in a single place per op type (ReadCommand / RowMutationCommand) ?"


> Enhance how metrics are exposed
> -------------------------------
>
>                 Key: CASSANDRA-272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-272
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: 0.3
>            Reporter: Sammy Yu
>            Assignee: Sammy Yu
>            Priority: Minor
>             Fix For: 0.3
>
>
> Had discussion on IRC about the metric interfaces that are used in the code today.  There are two sets one using IAnalyticsSource to send data to Gangalia and another set of interface using JMX MBeans (ie, ColumnStoreFamily).  
> Since FB is not using Gangalia anymore and it looks like the other VMAnalyticsSource is already available via JMX, we should prefer to expose metrics through JMX.  I will add a new TableMBean which exposes the metrics in  DBAnalyticsSource.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CASSANDRA-272) Enhance how metrics are exposed

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727825#action_12727825 ] 

Eric Evans edited comment on CASSANDRA-272 at 7/6/09 3:52 PM:
--------------------------------------------------------------

After some discussion on IRC between myself, Sammy, and Jonathan, it was decided that a) we'll go without a TableMBean unless/until there something Table-specific to expose, and b) we need a CFSMbean organization that is human readable in tools like jconsole. One possible way is by manipulating the object name to parent by the table name instead of the CF name.

      was (Author: urandom):
    After some discussion on IRC between myself, Sammy, and Jonathan, it was decided that a) we'll go without a TableMBean unless/until there something Table-specific to expose, and b) we need a CFSMbean organization that is human readable as well, possibly by manipulating the object name to parent by tablename instead of CF name.
  
> Enhance how metrics are exposed
> -------------------------------
>
>                 Key: CASSANDRA-272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-272
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: 0.3
>            Reporter: Sammy Yu
>            Assignee: Sammy Yu
>            Priority: Minor
>             Fix For: 0.3
>
>         Attachments: 0001--Work-for-cassandra-272.patch, 0002--Work-for-cassandra-272.patch
>
>
> Had discussion on IRC about the metric interfaces that are used in the code today.  There are two sets one using IAnalyticsSource to send data to Gangalia and another set of interface using JMX MBeans (ie, ColumnStoreFamily).  
> Since FB is not using Gangalia anymore and it looks like the other VMAnalyticsSource is already available via JMX, we should prefer to expose metrics through JMX.  I will add a new TableMBean which exposes the metrics in  DBAnalyticsSource.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-272) Enhance how metrics are exposed

Posted by "Sammy Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726250#action_12726250 ] 

Sammy Yu commented on CASSANDRA-272:
------------------------------------

It looks like there are some metrics between Tables and SystemColumnFamilies that don't overlap in particular the write metrics.  I will create a patch that does the initial changes for now by adding a TableMBean.  I will also add a new nodeprobe stats command that will retrieve these metrics via JMX:


Table: system
        Read Count: 0
        Read Latency: 0.000 ms.
        Write Count: 0
        Write Latency: 0.000 ms.
                Column Family: HintsColumnFamily
                Memtable Columns Count: 0
                Memtable Data Size: 0
                Memtable Switch Count: 0
                Read Count: 0
                Read Disk Count: 0
                Read Latency: 0.000 ms.

                Column Family: LocationInfo
                Memtable Columns Count: 2
                Memtable Data Size: 66
                Memtable Switch Count: 0
                Read Count: 0
                Read Disk Count: 0
                Read Latency: 0.000 ms.


> Enhance how metrics are exposed
> -------------------------------
>
>                 Key: CASSANDRA-272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-272
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: 0.3
>            Reporter: Sammy Yu
>            Assignee: Sammy Yu
>            Priority: Minor
>             Fix For: 0.3
>
>
> Had discussion on IRC about the metric interfaces that are used in the code today.  There are two sets one using IAnalyticsSource to send data to Gangalia and another set of interface using JMX MBeans (ie, ColumnStoreFamily).  
> Since FB is not using Gangalia anymore and it looks like the other VMAnalyticsSource is already available via JMX, we should prefer to expose metrics through JMX.  I will add a new TableMBean which exposes the metrics in  DBAnalyticsSource.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-272) Enhance how metrics are exposed

Posted by "Sammy Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sammy Yu updated CASSANDRA-272:
-------------------------------

    Attachment: 0002--Work-for-cassandra-272.patch

Self-contained patch, ignore previous 0001 patch.

> Enhance how metrics are exposed
> -------------------------------
>
>                 Key: CASSANDRA-272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-272
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: 0.3
>            Reporter: Sammy Yu
>            Assignee: Sammy Yu
>            Priority: Minor
>             Fix For: 0.3
>
>         Attachments: 0001--Work-for-cassandra-272.patch, 0002--Work-for-cassandra-272.patch
>
>
> Had discussion on IRC about the metric interfaces that are used in the code today.  There are two sets one using IAnalyticsSource to send data to Gangalia and another set of interface using JMX MBeans (ie, ColumnStoreFamily).  
> Since FB is not using Gangalia anymore and it looks like the other VMAnalyticsSource is already available via JMX, we should prefer to expose metrics through JMX.  I will add a new TableMBean which exposes the metrics in  DBAnalyticsSource.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-272) Enhance how metrics are exposed

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727801#action_12727801 ] 

Eric Evans commented on CASSANDRA-272:
--------------------------------------

I have a couple of concerns about the organization/layout of instrumentation here.

1. I'm not sure it makes sense to have per-CF statistics reported on the CFMbean and then aggregated/averaged on a TableMbean as well. Pretty much any monitoring application that I can think of would collect on the individual CF-specific values, at which point doing the math is straightforward. In short, I'm concerned this TableMbean will just be confusing if all it contains is information that can be derived elsewhere.

2. At first, I liked what you did here in reorganizing the individual CFSs under ColumnFamilyStores as opposed to object names formatted to include the tablename. Then I got to thinking about what this will look like under generic JMX tools like jconsole, if for example there are different tables that have identically named CFs. Thoughts?

Also, with respect to NodeProbe. When I originally put this together, I was thinking in terms of the class being useful in creating a real monitoring system. That's why there are instance variables for memory, runtime, and the storage service proxies/mbeans, even though no single command uses them all. I don't know if that really makes sense to keep doing as we add more and more instrumentation (especially if a monitoring system is vaporware, and the only use is via main()). Thoughts on this?

> Enhance how metrics are exposed
> -------------------------------
>
>                 Key: CASSANDRA-272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-272
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: 0.3
>            Reporter: Sammy Yu
>            Assignee: Sammy Yu
>            Priority: Minor
>             Fix For: 0.3
>
>         Attachments: 0001--Work-for-cassandra-272.patch, 0002--Work-for-cassandra-272.patch
>
>
> Had discussion on IRC about the metric interfaces that are used in the code today.  There are two sets one using IAnalyticsSource to send data to Gangalia and another set of interface using JMX MBeans (ie, ColumnStoreFamily).  
> Since FB is not using Gangalia anymore and it looks like the other VMAnalyticsSource is already available via JMX, we should prefer to expose metrics through JMX.  I will add a new TableMBean which exposes the metrics in  DBAnalyticsSource.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-272) Enhance how metrics are exposed

Posted by "Sammy Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sammy Yu updated CASSANDRA-272:
-------------------------------

    Attachment: 0004-Work-for-CASSANDRA-272.patch

Incorporated Eric's comments.

> Enhance how metrics are exposed
> -------------------------------
>
>                 Key: CASSANDRA-272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-272
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: 0.3
>            Reporter: Sammy Yu
>            Assignee: Sammy Yu
>            Priority: Minor
>             Fix For: 0.3
>
>         Attachments: 0001--Work-for-cassandra-272.patch, 0002--Work-for-cassandra-272.patch, 0003-Work-for-CASSANDRA-272.patch, 0004-Work-for-CASSANDRA-272.patch
>
>
> Had discussion on IRC about the metric interfaces that are used in the code today.  There are two sets one using IAnalyticsSource to send data to Gangalia and another set of interface using JMX MBeans (ie, ColumnStoreFamily).  
> Since FB is not using Gangalia anymore and it looks like the other VMAnalyticsSource is already available via JMX, we should prefer to expose metrics through JMX.  I will add a new TableMBean which exposes the metrics in  DBAnalyticsSource.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.